Support prepared_statement.close #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool! Can be rebased now since that spec is fixed. |
|
Ping for rebase :) |
jeremy
force-pushed
the
statement-close
branch
from
eb544e5
to
e254cd6
Compare
|
Done! |
jeremy
force-pushed
the
statement-close
branch
from
e254cd6
to
2926f0d
Compare
|
Looks like closing the statement handle is causing some knock-on memory allocation effects, I'm digging into this. |
Useful when caching prepared statements. Evicted statements can release server resources immediately rather than waiting for Ruby GC.
jeremy
force-pushed
the
statement-close
branch
from
2926f0d
to
ef5d61d
Compare
|
Based on the comments on https://dev.mysql.com/doc/refman/5.0/en/mysql-stmt-execute.html it appears that attempting to use a statement handle after you've freed it will segfault the client library instead of returning a clean error. Ideas:
|
sodabrew
added a commit
to sodabrew/mysql2
that referenced
this pull request
Sep 13, 2015
Support prepared_statement.close
sodabrew
added a commit
to sodabrew/mysql2
that referenced
this pull request
Sep 13, 2015
Support prepared_statement.close
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful when caching prepared statements. Evicted statements can release
server resources immediately rather than waiting for Ruby GC.