Fix issue #451. Use atom format as suggested in the php docs for http…

…://php.net/manual/en/class.datetime.php#datetime.constants.iso8601. A bit of a BC but really its a bug fix.
briannesbitt · Nov 10, 2015 · 643decd · 643decd
1 parent 5fdd579
commit 643decd
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/src/Carbon/Carbon.php b/src/Carbon/Carbon.php
@@ -1089,7 +1089,7 @@ public function toCookieString()
      */
     public function toIso8601String()
     {
-        return $this->format(static::ISO8601);
+        return $this->toAtomString();
     }
 
     /**

diff --git a/tests/Carbon/StringsTest.php b/tests/Carbon/StringsTest.php
@@ -112,7 +112,7 @@ public function testToCOOKIEString()
     public function testToIso8601String()
     {
         $d = Carbon::create(1975, 12, 25, 14, 15, 16);
-        $this->assertSame('1975-12-25T14:15:16-0500', $d->toIso8601String());
+        $this->assertSame('1975-12-25T14:15:16-05:00', $d->toIso8601String());
     }
     public function testToRC822String()
     {

diff --git a/tests/Carbon/TestingAidsTest.php b/tests/Carbon/TestingAidsTest.php
@@ -120,8 +120,8 @@ public function testTimeZoneWithTestValueSet()
         $notNow = Carbon::parse('2013-07-01 12:00:00', 'America/New_York');
         Carbon::setTestNow($notNow);
 
-        $this->assertSame('2013-07-01T12:00:00-0400', Carbon::parse('now')->toIso8601String());
-        $this->assertSame('2013-07-01T11:00:00-0500', Carbon::parse('now', 'America/Mexico_City')->toIso8601String());
-        $this->assertSame('2013-07-01T09:00:00-0700', Carbon::parse('now', 'America/Vancouver')->toIso8601String());
+        $this->assertSame('2013-07-01T12:00:00-04:00', Carbon::parse('now')->toIso8601String());
+        $this->assertSame('2013-07-01T11:00:00-05:00', Carbon::parse('now', 'America/Mexico_City')->toIso8601String());
+        $this->assertSame('2013-07-01T09:00:00-07:00', Carbon::parse('now', 'America/Vancouver')->toIso8601String());
     }
 }