Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISO 8601: Missing colon in timezone #451

Closed
MarkKremer opened this issue Oct 16, 2015 · 5 comments
Closed

ISO 8601: Missing colon in timezone #451

MarkKremer opened this issue Oct 16, 2015 · 5 comments

Comments

@MarkKremer
Copy link

Hello,

Shouldn't the toIso8601String() method have an colon between the hours and minutes in the timezone part?
1975-12-25T14:15:16-0500 becomes 1975-12-25T14:15:16-05:00

Spec: http://www.w3.org/TR/NOTE-datetime

Kind regards,

Mark Kremer
@dereuromark dereuromark mentioned this issue Oct 28, 2015
Closed
@dereuromark
Copy link
Contributor

We fixed it in Chronos using atom: cakephp/chronos#45
The PHP constant turns out to be wrong here..

@MarkKremer
Copy link
Author

Thanks!

@dereuromark
Copy link
Contributor

You should leave it open for Carbon though.
Here it is not fixed yet.

Just wanted to show you how it can be fixed.
Feel free to open a PR for this repo.

@MarkKremer MarkKremer reopened this Nov 1, 2015
@briannesbitt
Copy link
Owner

Ya... its a bit of a BC change but I guess more of a bug based on the PHP implementation.

briannesbitt added a commit that referenced this issue Nov 10, 2015
@briannesbitt
Fix issue #451. Use atom format as suggested in the php docs for http…
643decd 
…://php.net/manual/en/class.datetime.php#datetime.constants.iso8601.  A bit of a BC but really its a bug fix.
@egeriis
Copy link

egeriis commented Mar 16, 2016

@briannesbitt When will there be a release with this patch?

@dereuromark dereuromark mentioned this issue Jan 17, 2017
Closed
ameliaikeda pushed a commit to ameliaikeda/Carbon that referenced this issue Jan 17, 2017
Revert "Fix issue briannesbitt#451. Use atom format as suggested in t…
9057fd8 
…he php docs for http://php.net/manual/en/class.datetime.php#datetime.constants.iso8601.  A bit of a BC but really its a bug fix."

This reverts commit 643decd.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dereuromark @briannesbitt @egeriis @MarkKremer