Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Malay translation improvement #2213

Conversation

ashrafkamarudin
Copy link
Contributor

What does this PR change? What problem does it solve?

  • Commit 66069aa Fix direct translation of "Before" and "After". Although "Before" does mean "Sebelum" and "After" does mean "Selepas", but it changed when you use it with time or days.

  • Commit f6a9503 Added a variation of "a". For example "a year ago" translate to "setahun lepas" while "1 year ago" translate to "1 tahun lepas"

  • Commit 8b817c8 Added new translation to the list and fix wrong translation of "Yesterday". "Kelmarin" means 2 days ago or "Before Yesterday"

  • Commit e0c0750 Probably not worth mentioning, but for this commit, I added myself as one of the contributors for the translation if you allow it of course.

Side Note: You can trust me as I'm a local here in Malaysia and have been living here for all my life 👍

Thanks.

@kylekatarnls
Copy link
Collaborator

Thanks, I will update unit tests and merge it.

@kylekatarnls kylekatarnls self-assigned this Oct 3, 2020
@kylekatarnls kylekatarnls added the translation Rely to internationalization label Oct 3, 2020
@kylekatarnls kylekatarnls added this to the 2.41.0 milestone Oct 3, 2020
@kylekatarnls kylekatarnls merged commit d4f8e46 into briannesbitt:master Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation Rely to internationalization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants