Nested properties

[noirbizarre]

This pull request add support for searching and sorting on nested properties using dot-notation when declaring fields (ie. nested.property).

I tried updating the documentation but I'm not sure on where to put this.

This pull request fix #26.

[noirbizarre]

Hi !

Is there any chance this can be reviewed and if it fit, merged ?

If not, what can I do to make it mergeable ?

[noirbizarre]

Hi !
I just saw that you merged some pull-request but not this one and not any comment.

Is there any reason not to merge this one ?
If there is, what can I do/change to make it mergeable ?

[brianreavis]

This may make no visible change to the API, but it does come with a performance hit. If this is to be merged, it needs to either (1) be a completely different code path that's enabled via an option like nesting:true or (2) compile the accessor.

[noirbizarre]

Thanks for the feedback. I will adjust the PR.

I fear that the completely different path introduce too much complexity and maintainability drop.

I'm not sure about the second option meaning (compile the accessor), what do you mean by compile ? Make the getattr a native function ?

I just noted the benchmark task. I will try to find a solution with less performance hit.
What value do you find acceptable ?

[noirbizarre]

OK, I just:

• made the nesting optional with the nesting search option
• documented the parameter and the potential side-effect
• rebased on master

[holic]

Small nitpick: "performances" should be "performance"

Nevermind, will just fix this up in master :)

[holic]

Looks great. Thanks for the PR!