Test on armhf and use ubuntu's gcc packages. #174
Conversation
|
Coverage increased (+0.05%) to 63.815% when pulling 64f1d0e093b4f9153fe616378f51cc6b5fc3990b on pietro:armhf into 6ef767f on briansmith:master. |
| @@ -21,30 +21,22 @@ printenv | |||
|
|
|||
| case $TARGET_X in | |||
| aarch64-unknown-linux-gnu) | |||
| DL_TARGET=aarch64-linux-gnu | |||
| DL_DIGEST=b9137008744d9009877f662dbac7481d673cdcb1798e727e325a37c98a0f63da | |||
| sudo apt-get install --no-install-recommends g++-aarch64-linux-gnu gcc-aarch64-linux-gnu libc6-dev-arm64-cross -y | |||
There was a problem hiding this comment.
Do we need to use sudo apt-get install to install these, or can we add them as package dependencies the normal way in update_travis_yml.py?
If these packages can only be installed using sudo then please add a note to that effect so people can understand why we're doing this a different way. Otherwise, let's switch to the declarative way.
There was a problem hiding this comment.
Do we need to use sudo apt-get install to install these, or can we add them as package dependencies the normal way in update_travis_yml.py?
These packages are whitelisted by travis and can be declared on .travis.yml. I can move them there if you prefer. As for update_travis_yml.py the arm/aarch64 are not defined there. Should I take a stab at defining them there?
There was a problem hiding this comment.
I suggest that we just move this to .travis.yml for now.
I would love to get a seperate PR for doing the ARM/Aarch64 stuff in update-travis-yml.py, though! I only hard-coded them in .travis.yml because I didn't have time to do it properly.
|
Please add this to the end of your commit message: Thanks!: |
Use ubuntu's gcc packages for 32 and 64-bit ARM. Use travis_wait on slow arm tests. I agree to license my contributions to each file under the terms given at the top of each file I changed.
|
Great! This landed as 37892c5. Note that I redid the commit message a bit. Awesome contribution! |
And use travis_wait on slow arm tests.