Use only predefined environment variables to compute name prefixes. #1975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1975 +/- ##
=======================================
Coverage 96.29% 96.29%
=======================================
Files 136 136
Lines 20677 20677
Branches 226 226
=======================================
Hits 19910 19910
Misses 733 733
Partials 34 34 ☔ View full report in Codecov by Sentry. |
It seems like Cargo will rerun the build script automatically if some parts of Cargo.toml changes, but it isn't clear which changes to which parts trigger a rerun. Avoid depending on that by emitting "cargo:rerun-if-env-changed" for every variable read.
Instead of having build.rs set a custom environment variable, just compute the value directly from environment variables that are guaranteed to be set. This way, non-Cargo build systems can avoid duplicating this custom logic. Move the consistency check of `links` and the package version so that the check is also done during pregeneration. Use `read_env_var()` for the relevant environment variables so that build.rs emits `cargo:rerun-if-env-changed`, as it was noticed that Cargo otherwise doesn't seem to rerun the build script when the Cargo.toml values are changed.
briansmith
force-pushed
the
b/avoid-cargo-env
branch
from
9b77a1e
to
22bbb3b
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having build.rs set a custom environment variable, just compute the value directly from environment variables that are guaranteed to be set. This way, non-Cargo build systems can avoid duplicating this custom logic.
Move the consistency check of
linksand the package version so that the check is also done during pregeneration.Use
read_env_var()for the relevant environment variables so that build.rs emitscargo:rerun-if-env-changed, as it was noticed that Cargo otherwise doesn't seem to rerun the build script when the Cargo.toml values are changed.