Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use only predefined environment variables to compute name prefixes. #1975

Merged
merged 4 commits into from
Mar 1, 2024
Merged

Use only predefined environment variables to compute name prefixes. #1975

merged 4 commits into from
Mar 1, 2024

Commits on Feb 29, 2024

  1. build.rs: Rename read_env_var to env_var_os.

    @briansmith
    briansmith committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    55e3ae8 View commit details
    Browse the repository at this point in the history

  2. build.rs: Consistently emit "cargo:rerun-if-env-changed". 

    It seems like Cargo will rerun the build script automatically if some
parts of Cargo.toml changes, but it isn't clear which changes to which
parts trigger a rerun. Avoid depending on that by emitting
"cargo:rerun-if-env-changed" for every variable read.
    @briansmith
    briansmith committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    7743c85 View commit details
    Browse the repository at this point in the history

  3. build.rs: Avoid reading CARGO_MANIFEST_DIR redundantly.

    @briansmith
    briansmith committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    5167fb5 View commit details
    Browse the repository at this point in the history

  4. Use only predefined environment variables to compute name prefixes. 

    Instead of having build.rs set a custom environment variable, just
compute the value directly from environment variables that are
guaranteed to be set. This way, non-Cargo build systems can avoid
duplicating this custom logic.

Move the consistency check of `links` and the package version so that
the check is also done during pregeneration.

Use `read_env_var()` for the relevant environment variables so that
build.rs emits `cargo:rerun-if-env-changed`, as it was noticed that
Cargo otherwise doesn't seem to rerun the build script when the
Cargo.toml values are changed.
    @briansmith
    briansmith committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    22bbb3b View commit details
    Browse the repository at this point in the history