Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update directory structure #599

Closed
wants to merge 1 commit into from
Closed

Conversation

cramertj
Copy link

This PR moves around several files in order to
remove #![allow(legacy_directory_ownership)].
This will prevent breakage when the
legacy_directory_ownership warning becomes a hard
error.

cc #598

This PR moves around several files in order to
remove #![allow(legacy_directory_ownership)].
This will prevent breakage when the
legacy_directory_ownership warning becomes a hard
error.
@briansmith
Copy link
Owner

Instead of doing renames like src/aead/aead.rs → src/aead/mod.rs, please do renames like src/aead/aead.rs → src/aead.rs, using the new path rules.

@cramertj
Copy link
Author

@briansmith Oh, so you'd like to enable #![feature(non_modrs_mods)]?

@briansmith
Copy link
Owner

@briansmith Oh, so you'd like to enable #![feature(non_modrs_mods)]?

Sure, but the code needs to work in Stable Rust too. It sounds like the rustc developers need to come up with a migration plan.

@cramertj
Copy link
Author

cramertj commented Dec 22, 2017

@briansmith If you want this to work in stable rust, the only way to structure it is the way I have here. Once non_modrs_mods stabilizes, you can move over to using that structure.

@LovingMelody
Copy link

@cramertj You can always just move it to the way it was requested and then add a mod.rs to make what should be public public. Id say it would seem even messier though

@coveralls
Copy link

coveralls commented Dec 22, 2017

Coverage Status

Coverage increased (+0.4%) to 95.647% when pulling 149e06b on cramertj:mod-rs into 8411c00 on briansmith:master.

@jbg
Copy link

jbg commented Dec 24, 2017

It sounds like the rustc developers need to come up with a migration plan.

They did. If you disagree with it, this doesn't seem like the most productive way to indicate that, considering that ignoring the warnings that you weren't following the plan has broken ring for anyone who tracks rust nightly.

Repository owner locked and limited conversation to collaborators Dec 24, 2017
@briansmith
Copy link
Owner

I went ahead and locked this thread to minimize wasted effort on everybody's part. There's a large number of pending changes to ring that I want to merge before I rename any files. I'll try to get all these changes done by the end of January.

@briansmith
Copy link
Owner

The issue that this PR addresses was fixed in the 0.13.0-alpha release. Closing this.

@briansmith briansmith closed this Dec 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants