Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added NotRandom: A dummy random generator for testing. #771

Closed
wants to merge 1 commit into from

Conversation

realcr
Copy link

@realcr realcr commented Jan 23, 2019

This is an up to date pull request attempting to solve #661

This pull request adds NotRandom, a structure that implements SecureRandom and Sealed, allowing to write deterministic tests for random related cryptographic code.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.6%) to 93.806% when pulling 2fcfe98 on freedomlayer:real/feat/not-random into 5f67000 on briansmith:master.

@briansmith
Copy link
Owner

Hi, I'm going to close this for now. There are too many PRs open to address this issue and first we should figure out what we even want to do. If this turns out to be the approach we decide on then let's reopen this after we decide that.

@briansmith briansmith closed this Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants