Add more search support - BREAKING CHANGE

[Threpio]

Is required for this issue: spotify-cli #40

Changed the api.Search() function to take in an additional paramater of 'searchType)

FROM:
Search(q string, limit int)
TO:
Search(q, searchType string, limit int)

This will cause all the functionality within spotify-cli that uses the api.Search() to fail as it will require an additional parameter of 'tracks' to beadded

---

I have realised this included the changes from PR#4 accidentally - Do I need to remove this?

[brianstrauch]

Thanks for adding the type parameter to Search()! I'm not convinced we need the other two functions though. What do you think?

[Threpio]

As per your comments on the other PR I will separate these two and remove the other two functions by changing the play() one

[Threpio]

Play() now incorporates all that is required to play a specific album or playlist.

The other two redundant functions have been removed and the other PR closed without merge. This will require a small about of spotify-CLI refactoring

It is not known what happens if you pass a playlist as context_URI but with a song URI that is not in the playlist. If both are passed and the track is found within the playlist then the playlist will be played from that song onwards.

[Threpio]

I think they might need to be split up sadly.

[brianstrauch]

I think they might need to be split up sadly.

We can probably do an if statement like:

1. if contextURI != "", call Play() only with contextURI in the body.
2. else if len(uris) > 0, call Play() only with uris in the body.
3. else, call Play() with neither in the body.

[Threpio]

But that logic has to be done within the api.Play() function unless we split it out right? Because where we define the json fields is there

I will try and apply it - I might be a bit confusd though

[Threpio]

New push -

• We need to catch if both are set though?
• If both are set then we will be returned an error.

[brianstrauch]

Perfect! Left some picky comments about formatting. This is ready to merge once those get fixed!

[Threpio]

I know I could have 'commited suggestions' But I wanted to ensure that I had just missed the go fmt command locally and it still worked. All good I believe.

[brianstrauch]

Awesome! Thanks again for the PR, can't wait to see this in the CLI! I'll release v0.6.0 right now.

[Threpio]

Worth noting this was my first open source golang PR.

Glad it worked out on something I will use :)