Skip to content

Commit

Permalink
[4.0] Dashboard module options button (joomla#27529)
Browse files Browse the repository at this point in the history
I have no idea why but this cog icon button was given a class of btn-link. This meant that there was no visible indicator of focus. Removal of that class now means that you can visibly tab around the dashboard and see where you are
  • Loading branch information
brianteeman committed Feb 4, 2020
1 parent 6ec8079 commit e055e3a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion administrator/templates/atum/html/layouts/chromes/body.php
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
<?php if ($canEdit || $canChange) : ?>
<?php $dropdownPosition = Factory::getLanguage()->isRTL() ? 'left' : 'right'; ?>
<div class="module-actions dropdown">
<button type="button" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false" class="btn btn-link" id="dropdownMenuButton-<?php echo $id; ?>">
<button type="button" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false" class="btn" id="dropdownMenuButton-<?php echo $id; ?>">
<span class="fa fa-cog" aria-hidden="true"></span>
<span class="sr-only"><?php echo Text::sprintf('JACTION_EDIT_MODULE', $module->title); ?></span>
</button>
Expand Down
2 changes: 1 addition & 1 deletion administrator/templates/atum/html/layouts/chromes/well.php
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
<?php if ($canEdit || $canChange) : ?>
<?php $dropdownPosition = Factory::getLanguage()->isRTL() ? 'left' : 'right'; ?>
<div class="module-actions dropdown">
<button type="button" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false" class="btn btn-link" id="dropdownMenuButton-<?php echo $id; ?>">
<button type="button" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false" class="btn" id="dropdownMenuButton-<?php echo $id; ?>">
<span class="fa fa-cog" aria-hidden="true"></span>
<span class="sr-only"><?php echo Text::sprintf('JACTION_EDIT_MODULE', $module->title); ?></span>
</button>
Expand Down

0 comments on commit e055e3a

Please sign in to comment.