Fix URL quoting for collection info #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briantist
added
bug
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #72 +/- ##
==========================================
- Coverage 56.70% 56.59% -0.11%
==========================================
Files 26 26
Lines 947 947
==========================================
- Hits 537 536 -1
- Misses 410 411 +1
☔ View full report in Codecov by Sentry. |
|
Thanks! I'll try to update to this next week.
…On Thu, Jun 29, 2023, 1:49 PM Brian Scholer ***@***.***> wrote:
Fixes: #58 <#58>
Fixes: #52 <#52>
Closes: #54 <#54>
Closes: #71 <#71>
With devopshq/artifactory#409
<devopshq/artifactory#409> merged, the underlying
issue is fixed upstream, we just need to consume it by setting the
parameter appropriately since it currently defaults to previous behavior.
This PR does that, and to avoid guard code, it also sets the minimum
version of that library to the newly released v0.9.0 .
Huge thanks to @jcox10 <https://github.com/jcox10> @mamercad
<https://github.com/mamercad> for raising the issue and doing the heavy
troubleshooting!
------------------------------
You can view, comment on, or merge this pull request online at:
#72
Commit Summary
- 6c52080
<6c52080>
bump dohq-artifactory
- c827496
<c827496>
quote URL parameters
- 0c2c334
<0c2c334>
bump dohq-artifactory in setup.cfg
File Changes
(4 files <https://github.com/briantist/galactory/pull/72/files>)
- *M* galactory/upstream.py
<https://github.com/briantist/galactory/pull/72/files#diff-3c661a08c765d71ccb9e08e02d3051f64987ec16e79f808c603ccb655da5bbab>
(2)
- *M* galactory/utilities.py
<https://github.com/briantist/galactory/pull/72/files#diff-d3755cdfc363d098593dbd809d65fc2f6a2050cd17d8a1c00bb00b650c0d6526>
(9)
- *M* requirements.txt
<https://github.com/briantist/galactory/pull/72/files#diff-4d7c51b1efe9043e44439a949dfd92e5827321b34082903477fd04876edb7552>
(2)
- *M* setup.cfg
<https://github.com/briantist/galactory/pull/72/files#diff-fa602a8a75dc9dcc92261bac5f533c2a85e34fcceaff63b3a3a81d9acde2fc52>
(2)
Patch Links:
- https://github.com/briantist/galactory/pull/72.patch
- https://github.com/briantist/galactory/pull/72.diff
—
Reply to this email directly, view it on GitHub
<#72>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGCCVQGED643WQAEQNDNKVDXNXL43ANCNFSM6AAAAAAZY6HJYU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Thanks @jcox10 , you should be able to test this out from my branch: It would be great to get some additional local testing before merging (I'll be doing some tests too). |
|
Hey @jcox10 I'm going to be wrapping up my testing soon and will look to merge this unless I find any glaring issues. If you have a chance to try it out that'd be cool :) |
|
Sorry for the delay, been really busy. I finally tested it out by pulling the latest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #58
Fixes: #52
Closes: #54
Closes: #59
Closes: #71
With devopshq/artifactory#409 merged, the underlying issue is fixed upstream, we just need to consume it by setting the parameter appropriately since it currently defaults to previous behavior.
This PR does that, and to avoid guard code, it also sets the minimum version of that library to the newly released
v0.9.0.Huge thanks to @jcox10 @mamercad for raising the issue and doing the heavy troubleshooting!
Important
The malformation of collection info happened on publish, which, for collections uploaded (cached) via proxying, will have happened silently and then affected subsequent pulls.
The fix in this PR cannot fix collections which have already been published in artifactory with malformed
collection_info, so errors will still be seen trying to retrieve those.The collection info could be manually repaired, but the recommended fix is to republish.
For collections that were not proxied
I recommend re-publishing the collection (and probably delete the existing ones beforehand).
For collections that were proxied
I recommend deleting all (or all affected) proxied collections, and letting them get re-populated naturally on request.