fix: 🐛 fixed hack to use __rb_createdInstance on createPortal in rend…

…er.ts and in storybook. portal is now outside of transformnode -> box is moved from outside into node
brianzinn · Oct 26, 2021 · 1feee2f · 1feee2f
1 parent ed83c48
commit 1feee2f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/render.ts b/src/render.ts
@@ -30,7 +30,7 @@ export function createPortal(children: React.ReactNode, containerInfo: any, key?
     target = containerInfo.__rb_createdInstance;
   }
 
-  return reconciler.createPortal(children, containerInfo, null, key);
+  return reconciler.createPortal(children, target, null, key);
 }
 
 /*

diff --git a/storybook/stories/babylonjs/Basic/portal.stories.js b/storybook/stories/babylonjs/Basic/portal.stories.js
@@ -27,12 +27,12 @@ function WithCreatePortal() {
 
   return (
     <>
-      <transformNode name="transform-node" ref={transformNodeRef}>
-        {(transformNodeRef.current) &&
+      {(transformNodeRef.current) &&
           createPortal(<box position={new Vector3(0, 1, 0)}>
             <standardMaterial diffuseColor={Color3.Blue() } specularColor={Color3.Black()} />
-          </box>, transformNodeRef.current['__rb_createdInstance'])
+          </box>, transformNodeRef.current)
         }
+      <transformNode name="transform-node" ref={transformNodeRef}>
         <ground name='ground1' width={6} height={6} subdivisions={2} position={new Vector3(0, 0, 0)} />
       </transformNode>
     </>