fix: patch for React 18.2 rendering differences

brianzinn · Sep 3, 2022 · bc66dd8 · bc66dd8
1 parent 8eb4636
commit bc66dd8
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/packages/react-babylonjs/src/Engine.tsx b/packages/react-babylonjs/src/Engine.tsx
@@ -109,7 +109,8 @@ const ReactBabylonjsEngine: React.FC<EngineProps> = (props: EngineProps, context
     ...canvasProps
   } = props
 
-  const observerEnabled = renderOptions !== undefined && renderOptions.whenVisibleOnly === true && !isPaused
+  const observerEnabled =
+    renderOptions !== undefined && renderOptions.whenVisibleOnly === true && !isPaused
   useCanvasObserver(canvasRef, shouldRenderRef, observerEnabled, 0)
 
   useEffect(() => {
@@ -138,7 +139,10 @@ const ReactBabylonjsEngine: React.FC<EngineProps> = (props: EngineProps, context
 
       // TODO: here is where you could access your own render method
       engine.current!.scenes.forEach((scene) => {
-        scene.render()
+        // TODO (fix properly): in React 18.2 (not 18.0 or 18.1 if the camera is in a subcomponent it will be added in a future render!)
+        if (scene.cameras?.length > 0) {
+          scene.render()
+        }
       })
 
       if (onEndRenderLoopObservable.current.hasObservers()) {