Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "greater/less than or equal to" methods #50

Merged
merged 2 commits into from
Jul 11, 2022
Merged

Add "greater/less than or equal to" methods #50

merged 2 commits into from
Jul 11, 2022

Conversation

ihmels
Copy link
Contributor

@ihmels ihmels commented May 6, 2022

No description provided.

@solodkiy
Copy link
Contributor

solodkiy commented May 6, 2022

Could you please add tests to new methods?

@ihmels
Copy link
Contributor Author

ihmels commented May 8, 2022

I added some assertions to DurationTest::testCompareTo() as it was done in LocalDateTest::testCompareTo.

@BenMorel BenMorel merged commit 049ef60 into brick:master Jul 11, 2022
@BenMorel
Copy link
Member

Thank you!

@BenMorel BenMorel added this to the 0.4.2 milestone Jul 11, 2022
@ihmels ihmels deleted the patch-1 branch July 11, 2022 12:37
@BenMorel
Copy link
Member

Released as 0.4.2. Sorry for the delay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@solodkiy solodkiy solodkiy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ihmels @solodkiy @BenMorel