Bring back support for sub-minute offsets in PHP >= 8.1.7 #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiripudil
force-pushed
the
tz-seconds-precision
branch
from
9cb6c82
to
7a2e032
Compare
BenMorel
requested changes
May 19, 2023
There was a problem hiding this comment.
Thanks a lot for the quality work, and sorry for the delay @jiripudil!
Just a couple nitpicks and I'll merge it 👍
|
By the way, regarding the workaround for |
jiripudil
force-pushed
the
tz-seconds-precision
branch
from
7a2e032
to
8c69586
Compare
|
Hi, thanks, I've fixed the nitpicks and rebased the branch. Also it seems that the issue has been fixed already (php/php-src@f9117eb), so I've updated the workaround to only apply in affected PHP versions. |
jiripudil
force-pushed
the
tz-seconds-precision
branch
from
548e748
to
eaef022
Compare
BenMorel
approved these changes
Jun 20, 2023
|
Thank you, @jiripudil ! |
|
Released in 0.4.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #44