-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Audio being loaded from wrong url #30
Comments
4 tasks
solvedDev
pushed a commit
that referenced
this issue
Jun 3, 2021
* Added Basic Sound On Interactions - Some notifications will produce a click on closing - Opening Notifications produce a click - When an error occurs an error sound will play - After creating a project an confirmation sound will play * Added sound to most window button interactions To Do: - Add sound to tool bar - Search and replace needs sound - Compact Prettier Options need sound - Better sound implementation (define the source in one place in case a sound wants to be changed) - Add A system in case too many sounds want to play at once (in case of many errors) * Built Project * Audio Manager and Mute Setting - Added audio manager class to app - Added settings section and toggle to mute audio manager - Audio manager only allows 1 sound to play at a time to stop duplicate sounds. - Audio manager also allows for a global change in volume between all sounds * Added clicks to a few more elements - added click to most sidebars - added clicks to most buttons and toggles * Updated audio settings tab icon * Removed Commented Lines And Fixed Mute Button * Stopped error that was caused by audio manager I removed the audio manager instance from app.ts and all the lines that are calling an audio from app so I can fix the error in the meantime. * My Bad I forgot about this part * This is the last line of code that should give an error * checkpoint * found error source * removed conflict * fixed conflict again? * Reverted changes for real * Removed Commented Lines * Fixed Audio Manager Mute Setting Changed en.ts to make mute button more clear. Fixed wierd sound logic when using the mute setting. * Possible fix for missing audio in build * potential fix for #30 * Possibly Fixed audio manager looking in wrong directory? * Delete click5.ogg
solvedDev
added a commit
that referenced
this issue
Jun 9, 2021
* Added Basic Sound On Interactions - Some notifications will produce a click on closing - Opening Notifications produce a click - When an error occurs an error sound will play - After creating a project an confirmation sound will play * Added sound to most window button interactions To Do: - Add sound to tool bar - Search and replace needs sound - Compact Prettier Options need sound - Better sound implementation (define the source in one place in case a sound wants to be changed) - Add A system in case too many sounds want to play at once (in case of many errors) * Built Project * Audio Manager and Mute Setting - Added audio manager class to app - Added settings section and toggle to mute audio manager - Audio manager only allows 1 sound to play at a time to stop duplicate sounds. - Audio manager also allows for a global change in volume between all sounds * Added clicks to a few more elements - added click to most sidebars - added clicks to most buttons and toggles * Updated audio settings tab icon * Removed Commented Lines And Fixed Mute Button * Stopped error that was caused by audio manager I removed the audio manager instance from app.ts and all the lines that are calling an audio from app so I can fix the error in the meantime. * My Bad I forgot about this part * This is the last line of code that should give an error * checkpoint * found error source * removed conflict * fixed conflict again? * Reverted changes for real * Removed Commented Lines * Fixed Audio Manager Mute Setting Changed en.ts to make mute button more clear. Fixed wierd sound logic when using the mute setting. * Possible fix for missing audio in build * potential fix for #30 * Possibly Fixed audio manager looking in wrong directory? * Delete click5.ogg * Updated use duration on items Co-authored-by: solvedDev <33347616+solvedDev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
A 404 error is caused by an attempt to load audio files that are not being sent to the client.
To Reproduce
Steps to reproduce the behavior:
Observed behavior
No audio will play.
Expected behavior
Audio will play on certain buttons.
Platform (please complete the following information):
Additional context
The error is caused by a missing audio folder not being on the client side. I'm just not sure what the file path should be if the audio folder does not load on the client side.
The text was updated successfully, but these errors were encountered: