Fixed trello card about food preset having a too long use duration #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Some notifications will produce a click on closing - Opening Notifications produce a click - When an error occurs an error sound will play - After creating a project an confirmation sound will play
To Do: - Add sound to tool bar - Search and replace needs sound - Compact Prettier Options need sound - Better sound implementation (define the source in one place in case a sound wants to be changed) - Add A system in case too many sounds want to play at once (in case of many errors)
- Added audio manager class to app - Added settings section and toggle to mute audio manager - Audio manager only allows 1 sound to play at a time to stop duplicate sounds. - Audio manager also allows for a global change in volume between all sounds
- added click to most sidebars - added clicks to most buttons and toggles
I removed the audio manager instance from app.ts and all the lines that are calling an audio from app so I can fix the error in the meantime.
Changed en.ts to make mute button more clear. Fixed wierd sound logic when using the mute setting.
solvedDev
approved these changes
Jun 9, 2021
|
Sorry. I thought I had updated but I guess not. Will make sure to remember next time. |
|
No worries! I'll just give you push access to our repo so you can work on a new branch directly on our repo in the future. |
solvedDev
pushed a commit
that referenced
this pull request
Jan 7, 2023
Updated generator script file definition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed food preset to have a use duration of 1.6 because 32 was too long.
Motivation and Context
To fix this trello card
Types of changes
Checklist: