upd(Dash): faster file reads #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Joelant05
approved these changes
Dec 19, 2022
Merged
solvedDev
added a commit
that referenced
this pull request
Dec 23, 2022
## Changes: - Optimized file reads for Dash on our native builds (#803) - Optimized pack indexing to be faster on our native builds (#804) - Optimized "getBridgeFolderPath" function on our native builds (#807) - Updated block presets to the latest Minecraft release (0e4a282) ## Fixes: - Fixed drag & drop not working throughout our native app (#800) - Fixed incorrect warning message in "item_texture.json" file when texture path is not valid (4b0a22b) - Fixed error upon dropping files onto the native app on Windows (#802) - Fixed blank block preset not showing without HCF toggle activated (39b5715) - Fixed "requiresMatcher" not matching multiple experimental conditions correctly (ce55938)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tauri's native
readBinaryFileAPI seems to be incredible slow. Implementing our ownread_filecommand is 5x faster compared to the previous implementation on our native build.Motivation
closes #799