NMEA: Use ASIO functionality to receive NMEA sentences #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using low-level socket functions, let ASIO handle reading NMEA-over-UDP into a string buffer
antoine0183
force-pushed
the
asio-receive
branch
from
4d40702
to
f426102
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using low-level socket functions, let ASIO handle reading NMEA-over-UDP into a string buffer.
The bit of code being replaced was originally copy-pasted from
AISoverUDP.cppwhich has the very ominous warning//This is all with low level socket functions, not actually asio. Needs to be checked on Windows!. Using ASIO hopefully addresses that (although I don't have a Windows installation to test things there).