feat(terraform): include pods of kubernetes_deployment in kubernetes_pod checks (1/4) #3691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ugrave
force-pushed
the
deployment_pod_checks_1
branch
2 times, most recently
from
1c62bcf
to
d233a08
Compare
ugrave
changed the title
ugrave
force-pushed
the
deployment_pod_checks_1
branch
2 times, most recently
from
1a5d768
to
cc144bf
Compare
ugrave
changed the title
ugrave
force-pushed
the
deployment_pod_checks_1
branch
from
cc144bf
to
135cbff
Compare
gruebel
reviewed
Oct 28, 2022
checkov/terraform/checks/resource/kubernetes/AllowPrivilegeEscalation.py
Outdated
Show resolved
Hide resolved
ugrave
force-pushed
the
deployment_pod_checks_1
branch
from
135cbff
to
70b8df1
Compare
tronxd
approved these changes
Nov 3, 2022
| evaluated_keys_path = "spec" | ||
|
|
||
| template = spec.get("template") | ||
| if template and isinstance(template, list): |
There was a problem hiding this comment.
Suggested change
| if template and isinstance(template, list): | |
| if template and isinstance(template, list) and len(template) == 1: |
| if template and isinstance(template, list): | ||
| template = template[0] | ||
| template_spec = template.get("spec") | ||
| if template_spec and isinstance(template_spec, list): |
There was a problem hiding this comment.
Suggested change
| if template_spec and isinstance(template_spec, list): | |
| if template_spec and isinstance(template_spec, list) and len(template_spec) == 1: |
| evaluated_keys_path = "spec" | ||
|
|
||
| template = spec.get("template") | ||
| if template and isinstance(template, list): |
There was a problem hiding this comment.
Suggested change
| if template and isinstance(template, list): | |
| if template and isinstance(template, list) and len(template) == 1: |
| if template and isinstance(template, list): | ||
| template = template[0] | ||
| template_spec = template.get("spec") | ||
| if template_spec and isinstance(template_spec, list): |
There was a problem hiding this comment.
Suggested change
| if template_spec and isinstance(template_spec, list): | |
| if template_spec and isinstance(template_spec, list) and len(template_spec) == 1: |
| evaluated_keys_path = "spec" | ||
|
|
||
| template = spec.get("template") | ||
| if template and isinstance(template, list): |
There was a problem hiding this comment.
Suggested change
| if template and isinstance(template, list): | |
| if template and isinstance(template, list) and len(template) == 1: |
| if template and isinstance(template, list): | ||
| template = template[0] | ||
| template_spec = template.get("spec") | ||
| if template_spec and isinstance(template_spec, list): |
There was a problem hiding this comment.
Suggested change
| if template_spec and isinstance(template_spec, list): | |
| if template_spec and isinstance(template_spec, list) and len(template_spec) == 1: |
| evaluated_keys_path = "spec" | ||
|
|
||
| template = spec.get("template") | ||
| if template and isinstance(template, list): |
There was a problem hiding this comment.
Suggested change
| if template and isinstance(template, list): | |
| if template and isinstance(template, list) and len(template) == 1: |
| if template and isinstance(template, list): | ||
| template = template[0] | ||
| template_spec = template.get("spec") | ||
| if template_spec and isinstance(template_spec, list): |
There was a problem hiding this comment.
Suggested change
| if template_spec and isinstance(template_spec, list): | |
| if template_spec and isinstance(template_spec, list) and and len(template_spec) == 1: |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
This PR includes pods defined via
kubernetes_deploymentin pod checks . PR 1 of 4.Fixes #3690
New/Edited policies (Delete if not relevant)
Add resource: kubernetes_deployment, kubernetes_deployment_v1
Add resource: kubernetes_deployment, kubernetes_deployment_v1
Add resource: kubernetes_deployment, kubernetes_deployment_v1
Add resource: kubernetes_deployment, kubernetes_deployment_v1
Add resource: kubernetes_deployment, kubernetes_deployment_v1
Add resource: kubernetes_deployment, kubernetes_deployment_v1
Checklist: