Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(github): add CIS checks part 1. Most of the 1.1.x #3937

Merged
merged 3 commits into from
Nov 27, 2022
Merged

feat(github): add CIS checks part 1. Most of the 1.1.x #3937

merged 3 commits into from
Nov 27, 2022

Conversation

eurogig
Copy link
Contributor

@eurogig eurogig commented Nov 24, 2022

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Adds CIS Supply Chain Benchmark checks
1.1.4
1.1.5
1.1.6
Not 1.1.8 as it needs a new API call. For a future PR
1.1.9
1.1.10
1.1.11
1.1.15
1.1.17

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@eurogig eurogig requested a review from gruebel November 24, 2022 13:58
@gruebel gruebel changed the title feat(github_configuration): add CIS checks part 1. Most of the 1.1.x feat(github_000000000000742844): add CIS checks part 1. Most of the 1.1.x Nov 24, 2022
@gruebel gruebel changed the title feat(github_000000000000742844): add CIS checks part 1. Most of the 1.1.x feat(github_000000000000937758): add CIS checks part 1. Most of the 1.1.x Nov 24, 2022
@gruebel gruebel changed the title feat(github_000000000000937758): add CIS checks part 1. Most of the 1.1.x feat(github): add CIS checks part 1. Most of the 1.1.x Nov 24, 2022
@nimrodkor nimrodkor changed the base branch from master to main November 27, 2022 07:30
@nimrodkor nimrodkor merged commit bf3ef30 into bridgecrewio:main Nov 27, 2022
@marynaKK
Copy link
Contributor

marynaKK commented Dec 5, 2022

@eurogig I didn't see here 1.1.10 - Am I missing something?

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nimrodkor nimrodkor nimrodkor approved these changes

@gruebel gruebel Awaiting requested review from gruebel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eurogig @marynaKK @nimrodkor @gruebel