Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(terraform): combine tf plan and tf graphs for nested modules #4066

Merged
merged 24 commits into from
Dec 15, 2022
Merged

feat(terraform): combine tf plan and tf graphs for nested modules #4066

merged 24 commits into from
Dec 15, 2022

Conversation

achiar99
Copy link
Contributor

@achiar99 achiar99 commented Dec 13, 2022 •
edited
Loading

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

If nested modules and multi hops env is ON:
merge tf graph with tf plan graph to get correct graph checks for tf plan

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

gruebel
gruebel reviewed Dec 14, 2022
View reviewed changes
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, looks good so far

checkov/terraform/plan_runner.py Outdated Show resolved Hide resolved
checkov/terraform/deep_analysis_plan_graph_manager.py Outdated Show resolved Hide resolved
checkov/terraform/deep_analysis_plan_graph_manager.py Outdated Show resolved Hide resolved
checkov/terraform/deep_analysis_plan_graph_manager.py Outdated Show resolved Hide resolved
checkov/terraform/deep_analysis_plan_graph_manager.py Show resolved Hide resolved
@achiar99 achiar99 merged commit 85c4250 into main Dec 15, 2022
@achiar99 achiar99 deleted the combine-tf-plan-graph branch December 15, 2022 06:14
gruebel pushed a commit to gruebel/checkov that referenced this pull request Dec 15, 2022
@achiar99 @actions-user
feat(terraform): combine tf plan and tf graphs for nested modules (br…
518704f 
…idgecrewio#4066)

* combine tf plan and tf graphs for nested modules

* use const

* dry

* add test

* conflict

* mypy

* mypy

* test

* test

* comment

* pr comments

* pr comments

* no hardcoded

* fix

* uncomment flag
gruebel pushed a commit to gruebel/checkov that referenced this pull request Dec 15, 2022
@achiar99 @actions-user
feat(terraform): combine tf plan and tf graphs for nested modules (br…
7d8747a 
…idgecrewio#4066)

* combine tf plan and tf graphs for nested modules

* use const

* dry

* add test

* conflict

* mypy

* mypy

* test

* test

* comment

* pr comments

* pr comments

* no hardcoded

* fix

* uncomment flag
@gruebel gruebel mentioned this pull request Jan 20, 2023
Closed
@stromp
Copy link

stromp commented Aug 23, 2024

@achiar99 @gruebel we encountered the issue that when we enable deep-analysis, the skipping of the checks (via code comment) is not working anymore. Is this intended behavior?

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gruebel gruebel gruebel approved these changes

@YaaraVerner YaaraVerner YaaraVerner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@achiar99 @stromp @gruebel @YaaraVerner