Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(secrets): fix secrets crash when secret is non string #4077

Merged
merged 1 commit into from Dec 14, 2022

Conversation

Eliran-Turgeman
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

resolves #4075
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

New/Edited policies (Delete if not relevant)

Description

Include a description of what makes it a violation and any relevant external links.

Fix

How does someone fix the issue in code and/or in runtime?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gruebel gruebel merged commit 571ccdf into main Dec 14, 2022
@gruebel gruebel deleted the fix_omit_secrets_crash branch December 14, 2022 20:49
gruebel pushed a commit to gruebel/checkov that referenced this pull request Dec 15, 2022
…io#4077)

fix case when secret is non string

Co-authored-by: Eliran Turgeman <elturgeman@paloaltonetworks.com>
gruebel pushed a commit to gruebel/checkov that referenced this pull request Dec 15, 2022
…io#4077)

fix case when secret is non string

Co-authored-by: Eliran Turgeman <elturgeman@paloaltonetworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when running a scan against a plan output
2 participants