fix(github): Fix GHA IR resource names in case of 2 identical images #4108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 19, 2022 14:56
lirshindalman
approved these changes
Dec 19, 2022
nimrodkor
approved these changes
Dec 19, 2022
gruebel
approved these changes
Dec 19, 2022
Comment on lines
51
to
52
| start_line = [line_number for line_number, line in self.workflow_line_numbers if image in line | ||
| and line_number >= job_object[START_LINE]][0] |
There was a problem hiding this comment.
sneaky container images 😄
how about
Suggested change
| start_line = [line_number for line_number, line in self.workflow_line_numbers if image in line | |
| and line_number >= job_object[START_LINE]][0] | |
| start_line = [line_number for line_number, line in self.workflow_line_numbers[job_object[START_LINE]][0]:] if image in line] |
itai1357
pushed a commit
that referenced
this pull request
Dec 19, 2022
…4108) * fix gha ir resource names * fix fixture * iterate only over lines after jobs start line Co-authored-by: Eliran Turgeman <elturgeman@paloaltonetworks.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
In case the image name appears twice in the same file, we calculated its start & end lines by it's first reference in the file, which caused empty related_resource_ids for images.
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
New/Edited policies (Delete if not relevant)
Description
Include a description of what makes it a violation and any relevant external links.
Fix
How does someone fix the issue in code and/or in runtime?
Checklist: