feat(secrets): Keep original secrets data in runtime for further validation #4144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
checkov/secrets/coordinator.py
Outdated
| # should not have duplicates? - if duplicates allowed, implementation should be changed | ||
| # may be saved by file type first, then by key - or any other preprocessing that may help differ the secrets. | ||
|
|
||
| if check_result.get('result') == CheckResult.FAILED and enriched_secret.original_secret is not None: |
There was a problem hiding this comment.
We can check these conditions before creating the EnrichedSecret object, in the runner itself
gruebel
reviewed
Dec 25, 2022
|
|
||
|
|
||
| class EnrichedSecret: | ||
| __slots__ = ("original_secret", "bc_check_id", "resource") |
checkov/secrets/coordinator.py
Outdated
| class EnrichedSecret: | ||
| __slots__ = ("original_secret", "bc_check_id", "resource") | ||
|
|
||
| def __init__(self, original_secret: Optional[str], bc_check_id: str, resource: str): |
There was a problem hiding this comment.
Suggested change
| def __init__(self, original_secret: Optional[str], bc_check_id: str, resource: str): | |
| def __init__(self, original_secret: Optional[str], bc_check_id: str, resource: str) -> None: |
lirshindalman
approved these changes
Dec 26, 2022
Teko012
pushed a commit
to Teko012/checkov_fork_bridgecrewio
that referenced
this pull request
Dec 26, 2022
…dation (bridgecrewio#4144) * add original secrets data * fix mypy, flake8 * fix mypy? * add # noqa TC002 * cleanup * After talk to Eliran * last change * Elirans' change2 * Elirans' change2 * removed letter * remove print * add slots :) * fix * fix2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
added a class to save secrets data for further validation.
Checklist: