-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(terraform): Adding yaml based build time policies for corresponding PC run time policies #4265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gruebel
reviewed
Jan 19, 2023
checkov/terraform/checks/graph_checks/aws/S3BucketGlobalViewACLDisabled.yaml
Outdated
Show resolved
Hide resolved
gruebel
approved these changes
Jan 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, looks good 🏆
marynaKK
approved these changes
Jan 22, 2023
gruebel
pushed a commit
to gruebel/checkov
that referenced
this pull request
Jan 22, 2023
…ing PC run time policies (bridgecrewio#4265) * adding 2 YAML policies - S3 & Neptune security config * adding 2 YAML policies * adding 2 YAML policies * adding 2 YAML policies * added 2 YAML policies * updated the pass and fail cases * Updated terraform pass and fail cases * Deleted - AWS S3 global ACL view check
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
This PR has 1 YAML-based check (after modification) with detailed description below
1. Checkov Title - Ensure AWS Neptune cluster deletion protection is enabled
PC Policy ID - fd9b71b1-a601-4c6b-b6f2-a8290ece5680
PC Policy Title - AWS Neptune cluster deletion protection is disabled
Compliance standards -
MLPS 2.0 (Level 2)
,Secure Controls Framework (SCF) - 2022.2.1
Remediation: