Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gha): fix failing image retrieval in GHA IR #4268

Merged
merged 3 commits into from
Jan 17, 2023
Merged

feat(gha): fix failing image retrieval in GHA IR #4268

merged 3 commits into from
Jan 17, 2023

Conversation

maxamel
Copy link
Contributor

@maxamel maxamel commented Jan 16, 2023

This PR adds a safeguard for image retrieval in GHA IR and also adjusts the index of the image.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@maxamel maxamel marked this pull request as ready for review January 16, 2023 16:51
@maxamel maxamel requested a review from gruebel January 17, 2023 12:41
gruebel
gruebel approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏖️

@gruebel gruebel merged commit a2c65d7 into main Jan 17, 2023
@gruebel gruebel deleted the fix_gha_ir branch January 17, 2023 13:57
reemodo pushed a commit to reemodo/checkov that referenced this pull request Jan 22, 2023
@maxamel
feat(gha): fix failing image retrieval in GHA IR (bridgecrewio#4268)
355f9a5 
* fix failing image retrieval in GHA IR

* fix mypy issue

* fix according to suggestion in comments

Co-authored-by: Max Amelchenko <mamelchenko@paloaltonetworks.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gruebel gruebel gruebel approved these changes

@marynaKK marynaKK marynaKK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxamel @gruebel @marynaKK