Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(terraform): change terraform nested modules path separators #4319

Merged
merged 7 commits into from
Jan 25, 2023

Conversation

YaaraVerner
Copy link
Contributor

@YaaraVerner YaaraVerner commented Jan 24, 2023

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

change terraform nested modules path separator from [ to ([{ to ensure the separator won't be in the original paths.
for example: from main.tf[module/main.tf#0] to main.tf([{module/main.tf#0}])
adjust UT

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@YaaraVerner YaaraVerner changed the title change terraform nested modules path separators fix(terraform): change terraform nested modules path separators Jan 25, 2023
@YaaraVerner YaaraVerner marked this pull request as ready for review January 25, 2023 08:23
checkov/common/util/parser_utils.py Outdated Show resolved Hide resolved
@YaaraVerner YaaraVerner merged commit 7e43666 into main Jan 25, 2023
@YaaraVerner YaaraVerner deleted the change-nested-modules-path-separators branch January 25, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants