Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sca): catch exceptional error during SCA results polling #4331

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

gruebel
Copy link
Contributor

@gruebel gruebel commented Jan 25, 2023

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

  • when I tested the SCA scanning locally I got once a very strange JSON decode error, if this happens again, then we hopefully get the actual response and handle it more gracefully 🙂

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gruebel gruebel merged commit 4b54bc3 into bridgecrewio:main Jan 25, 2023
@gruebel gruebel deleted the catch-exceptional-error branch January 25, 2023 13:16
reemodo pushed a commit to reemodo/checkov that referenced this pull request Jan 25, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants