Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(arm): AKSLocalAdminDisabled #6334

Merged
merged 12 commits into from
Jun 9, 2024

Conversation

shoshiGit
Copy link
Contributor

@shoshiGit shoshiGit commented May 21, 2024

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

We converted the check AKSLocalAdminDisabled from TERRAFORM language to the ARM language so that it also works on resources that are defined in the ARM language.

Fixes # (issue)

Description

Ensure AKS local admin account is disabled.

Fix

To fix this issue, you need to ensure that the local admin account for AKS is disabled in your configuration.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@shoshiGit shoshiGit changed the title AKSLocalAdminDisabled feat(arm): AKSLocalAdminDisabled May 21, 2024
Copy link
Contributor

@ChanochShayner ChanochShayner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ChanochShayner ChanochShayner merged commit 9eb2d9d into bridgecrewio:main Jun 9, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants