Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(general): bitbucket integration test failure #6407

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

MrTomerLevi
Copy link
Contributor

@MrTomerLevi MrTomerLevi commented Jun 6, 2024

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

As we removed Image Referencer in #6386 the sca_image report is not longer generated for bitbucket files.
An integration test was expecting this report to exist in checkov_report_bitbucket_pipelines_cve.json file and failed.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@MrTomerLevi MrTomerLevi changed the title fix(general) - BitBucket integration test failure fix(general): bitbucket integration test failure Jun 6, 2024
self.assertGreaterEqual(len(reports), 2,
"expecting to have 2 reports at least, bitbucket_pipelines and sca_image")
report = json.load(f)
self.assertGreaterEqual(len(report), 1,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Old file format - array of 2 dicts :

[
   {"check_type": "bitbucket_pipeliens"...}.
    {"check_type": "sca_image"...}.
]

Modified file format - single dict:

{"check_type": "bitbucket_pipeliens"...}

Copy link
Contributor

@lirshindalman lirshindalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!!

@MrTomerLevi MrTomerLevi merged commit f7b505b into main Jun 6, 2024
45 of 46 checks passed
@MrTomerLevi MrTomerLevi deleted the fix/bitbucket-integration-test-failure branch June 6, 2024 10:35
pull bot pushed a commit to Julian-Louis/checkov that referenced this pull request Jun 6, 2024
fix(general) - BitBucket integration test failure

Co-authored-by: tlevi <tomerlevi1983@gmail.co>
pull bot pushed a commit to Julian-Louis/checkov that referenced this pull request Jun 6, 2024
fix(general) - BitBucket integration test failure

Co-authored-by: tlevi <tomerlevi1983@gmail.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants