Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unable to parse each.value object issue #359

Merged
merged 2 commits into from
Apr 27, 2023

Conversation

lonegunmanb
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Currently yor cannot parse existing tags like tags = each.value.tags. This pr fix this issue.

@lonegunmanb
Copy link
Contributor Author

Hi @nimrodkor, we'd like to use yor in our projects but we've encountered some bugs, would you please review this pr when you have time? Thanks!

@lonegunmanb
Copy link
Contributor Author

Greetings @nimrodkor & @gruebel, any chance to merge this pr? Thanks!

Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, nice work 🏆
Need to wait for an other colleague to approve, which could take an other day or two, because of public holidays 🏖️

@lonegunmanb
Copy link
Contributor Author

Thanks @gruebel for the update!

@gruebel gruebel merged commit 5846ae8 into bridgecrewio:main Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants