Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added identifier to differentiate between Primary and Secondary IDs #120

Merged
merged 10 commits into from Jun 20, 2019
Merged

added identifier to differentiate between Primary and Secondary IDs #120

merged 10 commits into from Jun 20, 2019

Conversation

The-Marvex
Copy link
Contributor

No description provided.

Added identifier for Primary id's
Updated test to support identifier for primary id
added function countPrimary
added countOfIDs function
added identifier to differentiate between secondary and primary ids
added identifier to differentiate between primary and secondary ids
@egonw egonw self-requested a review June 18, 2019 10:21
@egonw egonw self-assigned this Jun 18, 2019
@egonw
Copy link
Member

egonw commented Jun 18, 2019

Thanks. I'll look at this asap. One note, for future patches, can you plz make the commit messages as dense as possible. For example:

image

That can be just the detailed message as the first and only message. Because "Update X.java" does not add information.

@egonw egonw merged commit 8ff1ea7 into bridgedb:master Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants