New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rdf suppport #131
Rdf suppport #131
Conversation
updated fork
…oIDTool.java to org.bridgedb.tools.qc/src/org/bridgedb/tools/VoID/VoIDTool.java
@@ -0,0 +1,85 @@ | |||
package org.bridgedb.tools.VoID; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please add the missing copyright/license header.
- Please use only lower case characters in Java package names
import java.sql.SQLException; | ||
import java.sql.Statement; | ||
|
||
public class VoIDTool { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add JavaDoc.
public FileWriter file ; | ||
|
||
private String fileName; | ||
public VoIDTool(File f1, String fileName) throws IOException { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add JavaDoc.
Connection con = oldGdb.getConnection(); | ||
Statement st= con.createStatement(); | ||
for(DataSource ds : oldGdb.getCapabilities().getSupportedSrcDataSources()) { | ||
String sql = "SELECT * from "+(ds.getFullName()).toUpperCase(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this belongs in SimpleGdbImpl4
I'll fix it and update the pr. |
@egonw updated the PR |
I'll try to pull them in on Wednesday! Please start writing up the work you did in one or two final blog posts, outlining in how the new functionality is meant to be used. Not necessarily in a lot of technical detail, but focusing on why people should adopt it. |
No description provided.