Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rdf suppport #131

Merged
merged 7 commits into from Aug 26, 2019
Merged

Rdf suppport #131

merged 7 commits into from Aug 26, 2019

Conversation

The-Marvex
Copy link
Contributor

No description provided.

@@ -0,0 +1,85 @@
package org.bridgedb.tools.VoID;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please add the missing copyright/license header.
  2. Please use only lower case characters in Java package names

import java.sql.SQLException;
import java.sql.Statement;

public class VoIDTool {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add JavaDoc.

public FileWriter file ;

private String fileName;
public VoIDTool(File f1, String fileName) throws IOException {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add JavaDoc.

Connection con = oldGdb.getConnection();
Statement st= con.createStatement();
for(DataSource ds : oldGdb.getCapabilities().getSupportedSrcDataSources()) {
String sql = "SELECT * from "+(ds.getFullName()).toUpperCase();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this belongs in SimpleGdbImpl4

@The-Marvex
Copy link
Contributor Author

I'll fix it and update the pr.

@The-Marvex
Copy link
Contributor Author

@egonw updated the PR

@egonw
Copy link
Member

egonw commented Aug 19, 2019

I'll try to pull them in on Wednesday! Please start writing up the work you did in one or two final blog posts, outlining in how the new functionality is meant to be used. Not necessarily in a lot of technical detail, but focusing on why people should adopt it.

@egonw egonw added this to In progress in BridgeDb 3 Aug 26, 2019
@egonw egonw merged commit c2956a7 into bridgedb:master Aug 26, 2019
@egonw egonw moved this from In progress to Done in BridgeDb 3 Aug 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
BridgeDb 3
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants