Add SpaceAfterComment Linter #825

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@ivantsepp
Contributor

ivantsepp commented Aug 16, 2016

Adds a linter for #813.

This is a big PR (alot of it is tests) so definitely let me know what changes you would like to see in order to get this merged! (or if it should be merged at all).

The basic idea is to look at comment nodes and depending on the type, we do different things.

  • If it's :silent, we need to split by new lines since sass will combine consecutive comments // into one node. There is also an option to allow empty // comments.
  • If it's :normal, count the spaces after /*
  • If it's :loud, count the spaces after /*!

@sds sds added the enhancement label Aug 18, 2016

@sds

This comment has been minimized.

Show comment
Hide comment
@sds

sds Aug 18, 2016

Collaborator

Thanks for the detailed pull request, @ivantsepp.

Including thorough tests and documentation makes this much easier to 👍

Merged in 21d2444.

Collaborator

sds commented Aug 18, 2016

Thanks for the detailed pull request, @ivantsepp.

Including thorough tests and documentation makes this much easier to 👍

Merged in 21d2444.

@sds sds closed this Aug 18, 2016

@ivantsepp

This comment has been minimized.

Show comment
Hide comment
@ivantsepp

ivantsepp Aug 18, 2016

Contributor

Thanks for reviewing and merging!

Contributor

ivantsepp commented Aug 18, 2016

Thanks for reviewing and merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment