Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brigadier #520

Closed
Strandedpirate opened this issue Jun 20, 2018 · 8 comments
Closed

brigadier #520

Strandedpirate opened this issue Jun 20, 2018 · 8 comments
Labels
question Further information is requested

Comments

@Strandedpirate
Copy link

Strandedpirate commented Jun 20, 2018

Where is the brigadier npm package that is associated with this project?

I originally install this one but looking closer it years old and doesn't seem to have anything to do with brigade.
https://github.com/chge/brigadier

@technosophos
Copy link
Contributor

We haven't fully packaged it into NPM yet. It's entirely in the source code base here. I started toying around with separating it into a facade. That work is here: https://github.com/technosophos/brigtest. If you can give us some use cases, it might help us figure out how to slice this library up in the right way.

@technosophos technosophos added the question Further information is requested label Jun 23, 2018
@Strandedpirate
Copy link
Author

An official package would allow static type checking with either Typescript or babel.js and a better dev time experience in whatever IDE I'm using by seeing the available properties/methods on each object without having to constantly lookup the documentation.

@technosophos
Copy link
Contributor

Good point. And we'd like to add better support to VS Code, so this would help there.

@technosophos
Copy link
Contributor

I'm experimenting with this idea. If we do it well, it would make VS Code extensions and unit tests much easier to write, as well.

1 similar comment
@technosophos
Copy link
Contributor

I'm experimenting with this idea. If we do it well, it would make VS Code extensions and unit tests much easier to write, as well.

@kooba
Copy link
Contributor

kooba commented Nov 5, 2018

I wonder what's the status on packaging brigadier as npm package. I can see effort started here #585 and here @azure/brigadier but no updates were made for a while. We would like to use Typescript to write our brigade.js files but reference to the npm package would need to be added to worker's dependencies list to build our brigade.ts file on worker start.

@technosophos
Copy link
Contributor

I still plan on getting that finished. Currently, I'm in a rush to get a few other things done in time for KubeCon NA. But as soon as those are wrapped up, I'll finish this.

@radu-matei
Copy link
Contributor

You can find the package on npm - https://www.npmjs.com/package/@azure/brigadier

Closing, but feel free to reopen if you have additional questions.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants