WIP ref(worker): switch to @azure/brigadier #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still todo:
|
Closed
This refactors the Brigade internal library to use @Azure/brigadier. This contains breaking changes in the pathing.
This also intercepts and overrides `require("@azure/brigadier")` for brigade.js files.
technosophos
force-pushed
the
feat/refactor-npm-brigadier
branch
2 times, most recently
from
ae21bc7
to
1449798
Compare
radu-matei
reviewed
Jan 4, 2019
| @@ -1,11 +1,11 @@ | |||
| /** | |||
| * Module app is the main application runner. | |||
| */ | |||
| import * as events from "./events"; | |||
| import * as events from "@azure/brigadier/out/events"; | |||
There was a problem hiding this comment.
nit: I am mildly annoyed by the fact that /out/ should be included every time the package is used - I suspect there's a configuration property that can help us avoid this - I'll look into it tomorrow morning.
There was a problem hiding this comment.
Ok, mildly was an understatement.
There was a problem hiding this comment.
Update: found a solution for pretty import paths - not ideal, but will PR against Brigadier.
radu-matei
reviewed
Jan 4, 2019
brigade-worker/src/k8s.ts
Outdated
|
|
||
| constructor(job: jobs.Job, e: BrigadeEvent, project: Project) { | ||
| public init<T extends jobs.Job>(job: T, e: BrigadeEvent, project: Project) { | ||
| // init takes a generic so we can run this against mocks as well as against the real |
There was a problem hiding this comment.
nit: can the function comment be before the function definition?
radu-matei
approved these changes
Jan 4, 2019
technosophos
force-pushed
the
feat/refactor-npm-brigadier
branch
from
1449798
to
1e25161
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the Brigade internal library to use @Azure/brigadier. This contains breaking changes in the pathing. (See https://www.npmjs.com/package/@azure/brigadier)
This also intercepts and overrides
require("@azure/brigadier")for brigade.js files.