Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: do not automatically append build id from pod/job names #680

Closed
Strandedpirate opened this issue Oct 25, 2018 · 3 comments
Closed
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Strandedpirate
Copy link

Strandedpirate commented Oct 25, 2018

Requesting that the build id not be automatically appended to pod names because it's taking 26 chars of the 63 character limit.

I'm sure a lot of code is banking on the build id being a part of the pods name but it could be simply added as a label and referred to from there.

@technosophos
Copy link
Contributor

I'll have to check on the uniqueness constraints, but we might be able to do this

@radu-matei radu-matei added enhancement New feature or request help wanted good first issue Good for newcomers labels Jan 5, 2019
@radu-matei
Copy link
Contributor

radu-matei commented Oct 30, 2019

Pod names must be unique in Kubernetes:

For example, you can only have one Pod named “myapp-1234”. (source)

That being said, we could look into maybe leaving a truncated id in the pod name, and full build id as a label.

ref #679

@krancour
Copy link
Contributor

Closing due to staleness. Please do re-open if appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants