Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): Job imagePullSecrets is a string array, not string #503

Merged
merged 1 commit into from Jun 11, 2018
Merged

fix(docs): Job imagePullSecrets is a string array, not string #503

merged 1 commit into from Jun 11, 2018

Conversation

jarimatti
Copy link
Contributor

The documentation stated that imagePullSecrets type is string, but it is string[] (array of strings).

Doc fix: Job imagePullSecrets is a string array, not string.
7b9b1b0 
The documentation stated that imagePullSecrets type is string, but it is
a string array.
technosophos
technosophos approved these changes Jun 11, 2018
View reviewed changes
Copy link
Contributor

@technosophos technosophos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching and fixing the docs.

@technosophos technosophos merged commit 1ab0dd4 into brigadecore:master Jun 11, 2018
@jarimatti jarimatti deleted the image-pull-secrets-is-string-array branch June 12, 2018 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@technosophos technosophos technosophos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jarimatti @technosophos