This repository has been archived by the owner on Aug 14, 2018. It is now read-only.
✨ Upgraded member select dropdowns to choices.js #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pltaylor
reviewed
Apr 1, 2017
views/layout.pug
Outdated
| @@ -10,6 +10,7 @@ html | |||
| link(rel='stylesheet', href='/admin/css/vendors/bootstrap.css') | |||
| link(rel='stylesheet', href="https://cdnjs.cloudflare.com/ajax/libs/bootstrap-social/5.0.0/bootstrap-social.min.css") | |||
| link(rel='stylesheet', href="https://cdnjs.cloudflare.com/ajax/libs/bootstrap-daterangepicker/2.1.24/daterangepicker.css") | |||
| link(rel='stylesheet', href='https://rawgit.com/jshjohnson/Choices/7255fa42ceb89e74f6b0b03d4868e6fec9162e39/assets/styles/css/choices.css') | |||
There was a problem hiding this comment.
Should this be local? Or at least a cdn?
There was a problem hiding this comment.
rawgit is a cdn, though you're right, i'm using the limited development link. will update to the production one.
pltaylor
suggested changes
Apr 1, 2017
views/projects/settings.pug
Outdated
| //- } | ||
| //- } | ||
| //- $('.leads-select').multiselect(teamSelectSettings) | ||
| //- $('.members-select').multiselect(teamSelectSettings) |
There was a problem hiding this comment.
Gonna call out the commenting of code :)
There was a problem hiding this comment.
word, removing.
|
@pltaylor this should be good for another pass. |
pltaylor
approved these changes
Apr 1, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix the "members dropdown is way too long" issue. This adds both a truncated box and a search box for select menus.
This removed the images in the dropdown, but I think the added functionality outweighs that minor piece of sugar.
screenshot:
cc @pltaylor