Fix image filtering #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When #83 was merged, the `account` was changed from a fog model (responding to `#id`) to a hash with `#[]` key access. At some point, the key type has changed - potentially caused by a Ruby or `fog` change - from a symbol to a string. The key change meant that the image listings had a filter that was used by default but would filter anything without an owner ID of `nil`. That meant everything. The workaround was using `--show-all` which disabled this filter but then included other images that were not interesting. This fixes the key type to `String` for now which seems to work with several versions of Ruby and the latest fog gems. For: #GH-97
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When #83 was merged, the
accountwas changed from a fog model (responding to#id) to a hashwith
#[]key access.At some point, the key type has changed - potentially caused by a Ruby
or
fogchange - from a symbol to a string.The key change meant that the image listings had a filter that was used
by default but would filter anything without an owner ID of
nil. Thatmeant everything.
The workaround was using
--show-allwhich disabled this filter butthen included other images that were not interesting.
This fixes the key type to
Stringfor now which seems to work withseveral versions of Ruby and the latest fog gems.
For: #97