Skip to content

Commit

Permalink
Add more matrix builds for Actions (#229)
Browse files Browse the repository at this point in the history
* Add more matrix testing and remove now-broken travis testing file

* Update badge

* Add missing runs-on

* Try to fix the build

* Try again to fix tests

* Fix build badge

* Show build image properly

* Need to remove 18 due to some odd timeout issue
  • Loading branch information
bdeitte committed Jun 20, 2022
1 parent 4d7fe65 commit 5173e8c
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 22 deletions.
7 changes: 3 additions & 4 deletions .github/workflows/node.js.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,12 @@ on:
jobs:
build:

runs-on: ubuntu-latest

strategy:
matrix:
node-version: [12.x, 14.x, 16.x]
os: [ubuntu-latest, windows-latest]
node-version: [8.x, 10.x, 12.x, 14.x, 16.x]
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/

runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node-version }}
Expand Down
16 changes: 0 additions & 16 deletions .travis.yml

This file was deleted.

1 change: 1 addition & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ CHANGELOG
## 9.1.0 (2022-6-20)
* @zhyu Append standard Datadog tags from env vars (DD_ENTITY_ID, DD_ENV, DD_SERVICE, and DD_VERSION)
* @bdeitte Check if client is undefined before closing to fix error
* @bdeitte Start using GitHub Actions for tests and remove now-broken travis file
* @bdeitte Update testing dependencies

## 9.0.0 (2021-10-31)
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ includes all changes in the latest node-statsd and many additional changes, incl

hot-shots supports Node 8.x and higher.

[![Build Status](https://secure.travis-ci.org/brightcove/hot-shots.png?branch=master)](http://travis-ci.org/brightcove/hot-shots)
![Build Status](https://github.com/brightcove/hot-shots/actions/workflows/node.js.yml/badge.svg)

## Migrating from node-statsd

Expand Down
2 changes: 1 addition & 1 deletion test/errorHandling.js
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ describe('#errorHandling', () => {
statsd.send('test title');
});

if (serverType === 'tcp' && clientType === 'client') {
if (serverType === 'tcp' && clientType === 'client' && process.platform !== 'win32') {
describe('#tcpSocket', () => {

// ensure we restore the original `Date.now` after each test
Expand Down

0 comments on commit 5173e8c

Please sign in to comment.