Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewind response stream after saving to cache #1

Merged
merged 3 commits into from
Aug 14, 2019
Merged

Rewind response stream after saving to cache #1

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9867b83
fix exception
mitinsany Jul 23, 2019
611ed26
end of stream after first save into cache
mitinsany Jul 23, 2019
58994fa
Update Middleware.php
mitinsany Aug 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Middleware.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,9 @@ protected function get(string $key): ?FulfilledPromise
protected function save(string $key, ?ResponseInterface $response = null, int $ttl): bool
{
if ($response && $response->getStatusCode() === 200) {
return $this->cache->set($key, (string)$response->getBody(), $ttl);
$this->cache->set($key, (string)$response->getBody(), $ttl);
$response->getBody()->rewind();
return true;
pecuchet marked this conversation as resolved.
Show resolved Hide resolved
}

return false;
Expand Down