fix: Fix assertion with multiple video player instances. OS-15582 #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renderer diffrentiates between video player instances using the DelegateId. Derive WebMediaPlayerBrightsign from WebMediaPlayerDelegate::Observer and initialise WebMediaPlayerDelegate instance. Provide DelegateId when Observer requests for it to avoid assertion.
t-bashir-bs
added a commit
that referenced
this pull request
Apr 24, 2024
Added the Chromium patch for integrating Brightsign video player with Chromium. fix: Fix assertion with multiple video player instances. OS-15582 (#25) Renderer diffrentiates between video player instances using the DelegateId. Derive WebMediaPlayerBrightsign from WebMediaPlayerDelegate::Observer and initialise WebMediaPlayerDelegate instance. Provide DelegateId when Observer requests for it to avoid assertion. video: Compositor integration for Brightsign Video Player Brightsign video player uses a customised version of VideoHoleFrames, which sends video player factory and z-index of the video frames. These are handled as Overlay planes. Our custom BrightsignUnderlay strategy sends the geometry, opacity and visibility information via libvid. feat: WebMediaPlayerBrightsign: Set new is_video_tag param in vid_player_load (#32) WebMediaPlayerBrightsign: Set new is_video_tag param in vid_player_load feat: Add latest fixes to compositor integration for Brightsign VideoPlayer (#33) feat: Add latest fixes to compositor integration for Brightsign Video Player Update the existing BrightSign custom BrightsignUnderlay strategy code with the latest fixes that were made in the QtWebEngine version. fix: Pass attributes to video_player and correct conversion OS-16220 (#34) The html5 element attributes were not been set when passed to video_player_load. Also, some time parameters were being converted from std::chrono to int64 when passed to the c wrapper. However, they weren't being converted back correctly. Specifically the duration parameter when set to std::chrono::milliseconds::zero() was being treated as an int64 and therefore ending up with an incorrect negative value. fix: Add fix for single video with hwz cannot be hidden OS-16518 (#35) Cherry picked from: dc2f2de: feat: Add support for brightsign video player f4078f1: fix: Fix assertion with multiple video player instances. OS-15582 (#25) 8609bc5: video: Compositor integration for Brightsign Video Player 6e1d724: feat: WebMediaPlayerBrightsign: Set new is_video_tag param in vid_player_load (#32) 51d48c1: feat: Add latest fixes to compositor integration for Brightsign VideoPlayer (#33) 0febd19: fix: Pass attributes to video_player and correct conversion OS-16220 (#34) 55e3edd: fix: Add fix for single video with hwz cannot be hidden OS-16518 (#35)
t-bashir-bs
added a commit
that referenced
this pull request
Apr 25, 2024
Added the Chromium patch for integrating Brightsign video player with Chromium. fix: Fix assertion with multiple video player instances. OS-15582 (#25) Renderer diffrentiates between video player instances using the DelegateId. Derive WebMediaPlayerBrightsign from WebMediaPlayerDelegate::Observer and initialise WebMediaPlayerDelegate instance. Provide DelegateId when Observer requests for it to avoid assertion. video: Compositor integration for Brightsign Video Player Brightsign video player uses a customised version of VideoHoleFrames, which sends video player factory and z-index of the video frames. These are handled as Overlay planes. Our custom BrightsignUnderlay strategy sends the geometry, opacity and visibility information via libvid. feat: WebMediaPlayerBrightsign: Set new is_video_tag param in vid_player_load (#32) WebMediaPlayerBrightsign: Set new is_video_tag param in vid_player_load feat: Add latest fixes to compositor integration for Brightsign VideoPlayer (#33) feat: Add latest fixes to compositor integration for Brightsign Video Player Update the existing BrightSign custom BrightsignUnderlay strategy code with the latest fixes that were made in the QtWebEngine version. fix: Pass attributes to video_player and correct conversion OS-16220 (#34) The html5 element attributes were not been set when passed to video_player_load. Also, some time parameters were being converted from std::chrono to int64 when passed to the c wrapper. However, they weren't being converted back correctly. Specifically the duration parameter when set to std::chrono::milliseconds::zero() was being treated as an int64 and therefore ending up with an incorrect negative value. fix: Add fix for single video with hwz cannot be hidden OS-16518 (#35) Cherry picked from: dc2f2de: feat: Add support for brightsign video player f4078f1: fix: Fix assertion with multiple video player instances. OS-15582 (#25) 8609bc5: video: Compositor integration for Brightsign Video Player 6e1d724: feat: WebMediaPlayerBrightsign: Set new is_video_tag param in vid_player_load (#32) 51d48c1: feat: Add latest fixes to compositor integration for Brightsign VideoPlayer (#33) 0febd19: fix: Pass attributes to video_player and correct conversion OS-16220 (#34) 55e3edd: fix: Add fix for single video with hwz cannot be hidden OS-16518 (#35)
t-bashir-bs
added a commit
that referenced
this pull request
Apr 25, 2024
Added the Chromium patch for integrating Brightsign video player with Chromium. fix: Fix assertion with multiple video player instances. OS-15582 (#25) Renderer diffrentiates between video player instances using the DelegateId. Derive WebMediaPlayerBrightsign from WebMediaPlayerDelegate::Observer and initialise WebMediaPlayerDelegate instance. Provide DelegateId when Observer requests for it to avoid assertion. video: Compositor integration for Brightsign Video Player Brightsign video player uses a customised version of VideoHoleFrames, which sends video player factory and z-index of the video frames. These are handled as Overlay planes. Our custom BrightsignUnderlay strategy sends the geometry, opacity and visibility information via libvid. feat: WebMediaPlayerBrightsign: Set new is_video_tag param in vid_player_load (#32) WebMediaPlayerBrightsign: Set new is_video_tag param in vid_player_load feat: Add latest fixes to compositor integration for Brightsign VideoPlayer (#33) feat: Add latest fixes to compositor integration for Brightsign Video Player Update the existing BrightSign custom BrightsignUnderlay strategy code with the latest fixes that were made in the QtWebEngine version. fix: Pass attributes to video_player and correct conversion OS-16220 (#34) The html5 element attributes were not been set when passed to video_player_load. Also, some time parameters were being converted from std::chrono to int64 when passed to the c wrapper. However, they weren't being converted back correctly. Specifically the duration parameter when set to std::chrono::milliseconds::zero() was being treated as an int64 and therefore ending up with an incorrect negative value. fix: Add fix for single video with hwz cannot be hidden OS-16518 (#35) webmediaplayer_brightsign: Apply the fix for OnceCallback crash OS-16749 Applied the webmediaplayer_brightsign for the OnceCallback crash found in OS-16749. Cherry picked from: dc2f2de: feat: Add support for brightsign video player f4078f1: fix: Fix assertion with multiple video player instances. OS-15582 (#25) 8609bc5: video: Compositor integration for Brightsign Video Player 6e1d724: feat: WebMediaPlayerBrightsign: Set new is_video_tag param in vid_player_load (#32) 51d48c1: feat: Add latest fixes to compositor integration for Brightsign VideoPlayer (#33) 0febd19: fix: Pass attributes to video_player and correct conversion OS-16220 (#34) 55e3edd: fix: Add fix for single video with hwz cannot be hidden OS-16518 (#35) 7017af4: webmediaplayer_brightsign: Apply the fix for OnceCallback crash OS-16749
t-bashir-bs
added a commit
that referenced
this pull request
Apr 25, 2024
Added the Chromium patch for integrating Brightsign video player with Chromium. fix: Fix assertion with multiple video player instances. OS-15582 (#25) Renderer diffrentiates between video player instances using the DelegateId. Derive WebMediaPlayerBrightsign from WebMediaPlayerDelegate::Observer and initialise WebMediaPlayerDelegate instance. Provide DelegateId when Observer requests for it to avoid assertion. video: Compositor integration for Brightsign Video Player Brightsign video player uses a customised version of VideoHoleFrames, which sends video player factory and z-index of the video frames. These are handled as Overlay planes. Our custom BrightsignUnderlay strategy sends the geometry, opacity and visibility information via libvid. feat: WebMediaPlayerBrightsign: Set new is_video_tag param in vid_player_load (#32) WebMediaPlayerBrightsign: Set new is_video_tag param in vid_player_load feat: Add latest fixes to compositor integration for Brightsign VideoPlayer (#33) feat: Add latest fixes to compositor integration for Brightsign Video Player Update the existing BrightSign custom BrightsignUnderlay strategy code with the latest fixes that were made in the QtWebEngine version. fix: Pass attributes to video_player and correct conversion OS-16220 (#34) The html5 element attributes were not been set when passed to video_player_load. Also, some time parameters were being converted from std::chrono to int64 when passed to the c wrapper. However, they weren't being converted back correctly. Specifically the duration parameter when set to std::chrono::milliseconds::zero() was being treated as an int64 and therefore ending up with an incorrect negative value. fix: Add fix for single video with hwz cannot be hidden OS-16518 (#35) webmediaplayer_brightsign: Apply the fix for OnceCallback crash OS-16749 Applied the webmediaplayer_brightsign for the OnceCallback crash found in OS-16749. Cherry picked from: dc2f2de: feat: Add support for brightsign video player f4078f1: fix: Fix assertion with multiple video player instances. OS-15582 (#25) 8609bc5: video: Compositor integration for Brightsign Video Player 6e1d724: feat: WebMediaPlayerBrightsign: Set new is_video_tag param in vid_player_load (#32) 51d48c1: feat: Add latest fixes to compositor integration for Brightsign VideoPlayer (#33) 0febd19: fix: Pass attributes to video_player and correct conversion OS-16220 (#34) 55e3edd: fix: Add fix for single video with hwz cannot be hidden OS-16518 (#35) 7017af4: webmediaplayer_brightsign: Apply the fix for OnceCallback crash OS-16749
t-bashir-bs
added a commit
that referenced
this pull request
Apr 26, 2024
Added the Chromium patch for integrating Brightsign video player with Chromium. fix: Fix assertion with multiple video player instances. OS-15582 (#25) Renderer diffrentiates between video player instances using the DelegateId. Derive WebMediaPlayerBrightsign from WebMediaPlayerDelegate::Observer and initialise WebMediaPlayerDelegate instance. Provide DelegateId when Observer requests for it to avoid assertion. video: Compositor integration for Brightsign Video Player Brightsign video player uses a customised version of VideoHoleFrames, which sends video player factory and z-index of the video frames. These are handled as Overlay planes. Our custom BrightsignUnderlay strategy sends the geometry, opacity and visibility information via libvid. feat: WebMediaPlayerBrightsign: Set new is_video_tag param in vid_player_load (#32) WebMediaPlayerBrightsign: Set new is_video_tag param in vid_player_load feat: Add latest fixes to compositor integration for Brightsign VideoPlayer (#33) feat: Add latest fixes to compositor integration for Brightsign Video Player Update the existing BrightSign custom BrightsignUnderlay strategy code with the latest fixes that were made in the QtWebEngine version. fix: Pass attributes to video_player and correct conversion OS-16220 (#34) The html5 element attributes were not been set when passed to video_player_load. Also, some time parameters were being converted from std::chrono to int64 when passed to the c wrapper. However, they weren't being converted back correctly. Specifically the duration parameter when set to std::chrono::milliseconds::zero() was being treated as an int64 and therefore ending up with an incorrect negative value. fix: Add fix for single video with hwz cannot be hidden OS-16518 (#35) webmediaplayer_brightsign: Apply the fix for OnceCallback crash OS-16749 Applied the webmediaplayer_brightsign for the OnceCallback crash found in OS-16749. Cherry picked from: dc2f2de: feat: Add support for brightsign video player f4078f1: fix: Fix assertion with multiple video player instances. OS-15582 (#25) 8609bc5: video: Compositor integration for Brightsign Video Player 6e1d724: feat: WebMediaPlayerBrightsign: Set new is_video_tag param in vid_player_load (#32) 51d48c1: feat: Add latest fixes to compositor integration for Brightsign VideoPlayer (#33) 0febd19: fix: Pass attributes to video_player and correct conversion OS-16220 (#34) 55e3edd: fix: Add fix for single video with hwz cannot be hidden OS-16518 (#35) 7017af4: webmediaplayer_brightsign: Apply the fix for OnceCallback crash OS-16749
t-bashir-bs
added a commit
that referenced
this pull request
Apr 26, 2024
Added the Chromium patch for integrating Brightsign video player with Chromium. fix: Fix assertion with multiple video player instances. OS-15582 (#25) Renderer diffrentiates between video player instances using the DelegateId. Derive WebMediaPlayerBrightsign from WebMediaPlayerDelegate::Observer and initialise WebMediaPlayerDelegate instance. Provide DelegateId when Observer requests for it to avoid assertion. video: Compositor integration for Brightsign Video Player Brightsign video player uses a customised version of VideoHoleFrames, which sends video player factory and z-index of the video frames. These are handled as Overlay planes. Our custom BrightsignUnderlay strategy sends the geometry, opacity and visibility information via libvid. feat: WebMediaPlayerBrightsign: Set new is_video_tag param in vid_player_load (#32) WebMediaPlayerBrightsign: Set new is_video_tag param in vid_player_load feat: Add latest fixes to compositor integration for Brightsign VideoPlayer (#33) feat: Add latest fixes to compositor integration for Brightsign Video Player Update the existing BrightSign custom BrightsignUnderlay strategy code with the latest fixes that were made in the QtWebEngine version. fix: Pass attributes to video_player and correct conversion OS-16220 (#34) The html5 element attributes were not been set when passed to video_player_load. Also, some time parameters were being converted from std::chrono to int64 when passed to the c wrapper. However, they weren't being converted back correctly. Specifically the duration parameter when set to std::chrono::milliseconds::zero() was being treated as an int64 and therefore ending up with an incorrect negative value. fix: Add fix for single video with hwz cannot be hidden OS-16518 (#35) webmediaplayer_brightsign: Apply the fix for OnceCallback crash OS-16749 Applied the webmediaplayer_brightsign for the OnceCallback crash found in OS-16749. Cherry picked from: dc2f2de: feat: Add support for brightsign video player f4078f1: fix: Fix assertion with multiple video player instances. OS-15582 (#25) 8609bc5: video: Compositor integration for Brightsign Video Player 6e1d724: feat: WebMediaPlayerBrightsign: Set new is_video_tag param in vid_player_load (#32) 51d48c1: feat: Add latest fixes to compositor integration for Brightsign VideoPlayer (#33) 0febd19: fix: Pass attributes to video_player and correct conversion OS-16220 (#34) 55e3edd: fix: Add fix for single video with hwz cannot be hidden OS-16518 (#35) 7017af4: webmediaplayer_brightsign: Apply the fix for OnceCallback crash OS-16749
t-bashir-bs
added a commit
that referenced
this pull request
Apr 26, 2024
Added the Chromium patch for integrating Brightsign video player with Chromium. fix: Fix assertion with multiple video player instances. OS-15582 (#25) Renderer diffrentiates between video player instances using the DelegateId. Derive WebMediaPlayerBrightsign from WebMediaPlayerDelegate::Observer and initialise WebMediaPlayerDelegate instance. Provide DelegateId when Observer requests for it to avoid assertion. video: Compositor integration for Brightsign Video Player Brightsign video player uses a customised version of VideoHoleFrames, which sends video player factory and z-index of the video frames. These are handled as Overlay planes. Our custom BrightsignUnderlay strategy sends the geometry, opacity and visibility information via libvid. feat: WebMediaPlayerBrightsign: Set new is_video_tag param in vid_player_load (#32) WebMediaPlayerBrightsign: Set new is_video_tag param in vid_player_load feat: Add latest fixes to compositor integration for Brightsign VideoPlayer (#33) feat: Add latest fixes to compositor integration for Brightsign Video Player Update the existing BrightSign custom BrightsignUnderlay strategy code with the latest fixes that were made in the QtWebEngine version. fix: Pass attributes to video_player and correct conversion OS-16220 (#34) The html5 element attributes were not been set when passed to video_player_load. Also, some time parameters were being converted from std::chrono to int64 when passed to the c wrapper. However, they weren't being converted back correctly. Specifically the duration parameter when set to std::chrono::milliseconds::zero() was being treated as an int64 and therefore ending up with an incorrect negative value. fix: Add fix for single video with hwz cannot be hidden OS-16518 (#35) webmediaplayer_brightsign: Apply the fix for OnceCallback crash OS-16749 Applied the webmediaplayer_brightsign for the OnceCallback crash found in OS-16749. Cherry picked from: dc2f2de: feat: Add support for brightsign video player f4078f1: fix: Fix assertion with multiple video player instances. OS-15582 (#25) 8609bc5: video: Compositor integration for Brightsign Video Player 6e1d724: feat: WebMediaPlayerBrightsign: Set new is_video_tag param in vid_player_load (#32) 51d48c1: feat: Add latest fixes to compositor integration for Brightsign VideoPlayer (#33) 0febd19: fix: Pass attributes to video_player and correct conversion OS-16220 (#34) 55e3edd: fix: Add fix for single video with hwz cannot be hidden OS-16518 (#35) 7017af4: webmediaplayer_brightsign: Apply the fix for OnceCallback crash OS-16749
t-bashir-bs
added a commit
that referenced
this pull request
Apr 26, 2024
Added the Chromium patch for integrating Brightsign video player with Chromium. fix: Fix assertion with multiple video player instances. OS-15582 (#25) Renderer diffrentiates between video player instances using the DelegateId. Derive WebMediaPlayerBrightsign from WebMediaPlayerDelegate::Observer and initialise WebMediaPlayerDelegate instance. Provide DelegateId when Observer requests for it to avoid assertion. video: Compositor integration for Brightsign Video Player Brightsign video player uses a customised version of VideoHoleFrames, which sends video player factory and z-index of the video frames. These are handled as Overlay planes. Our custom BrightsignUnderlay strategy sends the geometry, opacity and visibility information via libvid. feat: WebMediaPlayerBrightsign: Set new is_video_tag param in vid_player_load (#32) WebMediaPlayerBrightsign: Set new is_video_tag param in vid_player_load feat: Add latest fixes to compositor integration for Brightsign VideoPlayer (#33) feat: Add latest fixes to compositor integration for Brightsign Video Player Update the existing BrightSign custom BrightsignUnderlay strategy code with the latest fixes that were made in the QtWebEngine version. fix: Pass attributes to video_player and correct conversion OS-16220 (#34) The html5 element attributes were not been set when passed to video_player_load. Also, some time parameters were being converted from std::chrono to int64 when passed to the c wrapper. However, they weren't being converted back correctly. Specifically the duration parameter when set to std::chrono::milliseconds::zero() was being treated as an int64 and therefore ending up with an incorrect negative value. fix: Add fix for single video with hwz cannot be hidden OS-16518 (#35) webmediaplayer_brightsign: Apply the fix for OnceCallback crash OS-16749 Applied the webmediaplayer_brightsign for the OnceCallback crash found in OS-16749. Cherry picked from: dc2f2de: feat: Add support for brightsign video player f4078f1: fix: Fix assertion with multiple video player instances. OS-15582 (#25) 8609bc5: video: Compositor integration for Brightsign Video Player 6e1d724: feat: WebMediaPlayerBrightsign: Set new is_video_tag param in vid_player_load (#32) 51d48c1: feat: Add latest fixes to compositor integration for Brightsign VideoPlayer (#33) 0febd19: fix: Pass attributes to video_player and correct conversion OS-16220 (#34) 55e3edd: fix: Add fix for single video with hwz cannot be hidden OS-16518 (#35) 7017af4: webmediaplayer_brightsign: Apply the fix for OnceCallback crash OS-16749
t-bashir-bs
added a commit
that referenced
this pull request
Apr 26, 2024
Added the Chromium patch for integrating Brightsign video player with Chromium. fix: Fix assertion with multiple video player instances. OS-15582 (#25) Renderer diffrentiates between video player instances using the DelegateId. Derive WebMediaPlayerBrightsign from WebMediaPlayerDelegate::Observer and initialise WebMediaPlayerDelegate instance. Provide DelegateId when Observer requests for it to avoid assertion. video: Compositor integration for Brightsign Video Player Brightsign video player uses a customised version of VideoHoleFrames, which sends video player factory and z-index of the video frames. These are handled as Overlay planes. Our custom BrightsignUnderlay strategy sends the geometry, opacity and visibility information via libvid. feat: WebMediaPlayerBrightsign: Set new is_video_tag param in vid_player_load (#32) WebMediaPlayerBrightsign: Set new is_video_tag param in vid_player_load feat: Add latest fixes to compositor integration for Brightsign VideoPlayer (#33) feat: Add latest fixes to compositor integration for Brightsign Video Player Update the existing BrightSign custom BrightsignUnderlay strategy code with the latest fixes that were made in the QtWebEngine version. fix: Pass attributes to video_player and correct conversion OS-16220 (#34) The html5 element attributes were not been set when passed to video_player_load. Also, some time parameters were being converted from std::chrono to int64 when passed to the c wrapper. However, they weren't being converted back correctly. Specifically the duration parameter when set to std::chrono::milliseconds::zero() was being treated as an int64 and therefore ending up with an incorrect negative value. fix: Add fix for single video with hwz cannot be hidden OS-16518 (#35) webmediaplayer_brightsign: Apply the fix for OnceCallback crash OS-16749 Applied the webmediaplayer_brightsign for the OnceCallback crash found in OS-16749. Cherry picked from: dc2f2de: feat: Add support for brightsign video player f4078f1: fix: Fix assertion with multiple video player instances. OS-15582 (#25) 8609bc5: video: Compositor integration for Brightsign Video Player 6e1d724: feat: WebMediaPlayerBrightsign: Set new is_video_tag param in vid_player_load (#32) 51d48c1: feat: Add latest fixes to compositor integration for Brightsign VideoPlayer (#33) 0febd19: fix: Pass attributes to video_player and correct conversion OS-16220 (#34) 55e3edd: fix: Add fix for single video with hwz cannot be hidden OS-16518 (#35) 7017af4: webmediaplayer_brightsign: Apply the fix for OnceCallback crash OS-16749
t-bashir-bs
added a commit
that referenced
this pull request
Apr 29, 2024
Added the Chromium patch for integrating Brightsign video player with Chromium. fix: Fix assertion with multiple video player instances. OS-15582 (#25) Renderer diffrentiates between video player instances using the DelegateId. Derive WebMediaPlayerBrightsign from WebMediaPlayerDelegate::Observer and initialise WebMediaPlayerDelegate instance. Provide DelegateId when Observer requests for it to avoid assertion. video: Compositor integration for Brightsign Video Player Brightsign video player uses a customised version of VideoHoleFrames, which sends video player factory and z-index of the video frames. These are handled as Overlay planes. Our custom BrightsignUnderlay strategy sends the geometry, opacity and visibility information via libvid. feat: WebMediaPlayerBrightsign: Set new is_video_tag param in vid_player_load (#32) WebMediaPlayerBrightsign: Set new is_video_tag param in vid_player_load feat: Add latest fixes to compositor integration for Brightsign VideoPlayer (#33) feat: Add latest fixes to compositor integration for Brightsign Video Player Update the existing BrightSign custom BrightsignUnderlay strategy code with the latest fixes that were made in the QtWebEngine version. fix: Pass attributes to video_player and correct conversion OS-16220 (#34) The html5 element attributes were not been set when passed to video_player_load. Also, some time parameters were being converted from std::chrono to int64 when passed to the c wrapper. However, they weren't being converted back correctly. Specifically the duration parameter when set to std::chrono::milliseconds::zero() was being treated as an int64 and therefore ending up with an incorrect negative value. fix: Add fix for single video with hwz cannot be hidden OS-16518 (#35) webmediaplayer_brightsign: Apply the fix for OnceCallback crash OS-16749 Applied the webmediaplayer_brightsign for the OnceCallback crash found in OS-16749. Cherry picked from: dc2f2de: feat: Add support for brightsign video player f4078f1: fix: Fix assertion with multiple video player instances. OS-15582 (#25) 8609bc5: video: Compositor integration for Brightsign Video Player 6e1d724: feat: WebMediaPlayerBrightsign: Set new is_video_tag param in vid_player_load (#32) 51d48c1: feat: Add latest fixes to compositor integration for Brightsign VideoPlayer (#33) 0febd19: fix: Pass attributes to video_player and correct conversion OS-16220 (#34) 55e3edd: fix: Add fix for single video with hwz cannot be hidden OS-16518 (#35) 7017af4: webmediaplayer_brightsign: Apply the fix for OnceCallback crash OS-16749
caneraltinbasak
pushed a commit
that referenced
this pull request
Apr 30, 2024
Added the Chromium patch for integrating Brightsign video player with Chromium. fix: Fix assertion with multiple video player instances. OS-15582 (#25) Renderer diffrentiates between video player instances using the DelegateId. Derive WebMediaPlayerBrightsign from WebMediaPlayerDelegate::Observer and initialise WebMediaPlayerDelegate instance. Provide DelegateId when Observer requests for it to avoid assertion. video: Compositor integration for Brightsign Video Player Brightsign video player uses a customised version of VideoHoleFrames, which sends video player factory and z-index of the video frames. These are handled as Overlay planes. Our custom BrightsignUnderlay strategy sends the geometry, opacity and visibility information via libvid. feat: WebMediaPlayerBrightsign: Set new is_video_tag param in vid_player_load (#32) WebMediaPlayerBrightsign: Set new is_video_tag param in vid_player_load feat: Add latest fixes to compositor integration for Brightsign VideoPlayer (#33) feat: Add latest fixes to compositor integration for Brightsign Video Player Update the existing BrightSign custom BrightsignUnderlay strategy code with the latest fixes that were made in the QtWebEngine version. fix: Pass attributes to video_player and correct conversion OS-16220 (#34) The html5 element attributes were not been set when passed to video_player_load. Also, some time parameters were being converted from std::chrono to int64 when passed to the c wrapper. However, they weren't being converted back correctly. Specifically the duration parameter when set to std::chrono::milliseconds::zero() was being treated as an int64 and therefore ending up with an incorrect negative value. fix: Add fix for single video with hwz cannot be hidden OS-16518 (#35) webmediaplayer_brightsign: Apply the fix for OnceCallback crash OS-16749 Applied the webmediaplayer_brightsign for the OnceCallback crash found in OS-16749. Cherry picked from: dc2f2de: feat: Add support for brightsign video player f4078f1: fix: Fix assertion with multiple video player instances. OS-15582 (#25) 8609bc5: video: Compositor integration for Brightsign Video Player 6e1d724: feat: WebMediaPlayerBrightsign: Set new is_video_tag param in vid_player_load (#32) 51d48c1: feat: Add latest fixes to compositor integration for Brightsign VideoPlayer (#33) 0febd19: fix: Pass attributes to video_player and correct conversion OS-16220 (#34) 55e3edd: fix: Add fix for single video with hwz cannot be hidden OS-16518 (#35) 7017af4: webmediaplayer_brightsign: Apply the fix for OnceCallback crash OS-16749
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renderer diffrentiates between video player instances using the DelegateId. Derive WebMediaPlayerBrightsign from
WebMediaPlayerDelegate::Observer and initialise WebMediaPlayerDelegate instance. Provide DelegateId when Observer requests for it to avoid assertion.
Description of Change
Checklist
npm testpassesRelease Notes
Notes: