forked from electron/electron
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Cherry pick BrightSign custom changes onto 28-x-y-bs #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* workflows: Copy across BrightSign CI workflows from dev. * workflows: Temp change to debug new auth method * workflows: Another temp hack to debug * workflows: Another temp hack to debug * workflows: Change to use Github App authentication instead of using a PAT token. * workflows: Use version of ec2 runner with a fix for authentication in stop case. * workflows: Update ec2 runner version again. * workflows: Update to an AMI image that has pkg-config installed. * workflows: Use new leave_ec2_instance_running debug parameter from the ec2 runner action * workflows: Temp hack to stop EC2 instances being terminated after test run to debug failures. * workflows: Update to the ami that has pkg-config installed. * workflows: Update to a newer ami image that has dependencies installed properly. * workflows: Remove hack that set leave_ec2_instance_running to true for debugging purposes. * workflows: Switch to correct AWS account. OS-14873: Switch to using chromium export_tarball.py (#10) * workflows: Switch to using chromium export_tarball.py to create src tarball for release * workflows: Use ELECTRON_VERSION env var when calling export_tarball.py * workflows: Add missing $ when accessing env.SOURCE_RELEASE_FILE_NAME * workflows: Set src tarball upload to be after gclient sync again * workflows: Fix electron_package_name from .tgz to .gz * workflows: Remove commented out line Cherry picked from: 23ffb1e: feat: OS-14592 Create BrightSign CI workflows 5027fb7: OS-14873: Switch to using chromium export_tarball.py (#10)
* transparent redirect: Make redirects from one file to another transparent * webRequest: Add new test case to api-web-request-spec for transparent and normal redirects fix: Clear content-type and last modified from file fetches: OS-16593 (#39) Clear content-type and last modified from file fetches: OS-16593 Cherry picked from: b84c835: feat: OS-14993 Make redirects from one file to another transparent (#12) 558b42d: fix: Clear content-type and last modified from file fetches: OS-16593 (#39)
Description of Change Allow the passing of a quota to the session.fromPartition() API. This patch allows partitions to have a quota size, which in turn persuades the storage manager to run a garbage collector(at specific times) to free reclaimable storage space. Checklist - [x] PR description included and stakeholders cc'd - [x] npm test passes - [x] tests are [changed or added](https://github.com/electron/electron/blob/main/docs/development/testing.md) - [x] relevant documentation is changed or added - [x] [PR release notes](https://github.com/electron/clerk/blob/master/README.md) describe the change in a way relevant to app developers, and are [capitalized, punctuated, and past tense](https://github.com/electron/clerk/blob/master/README.md#examples). Release Notes notes: Allow the passing of a quota to the session.fromPath() API. Cherry picked from: 9555dc9: feat : backport, Allow partitions to have app set quotas OS-14197 (#14)
* wayland: Add BrightSign custom set-z-index feature A custom feature has been added to BrightSign Weston server to enable a z-index to be set to top level xdg windows. This patch adds the functionality into third_party/wayland and chromium ui/ozone/platform/wayland. * wayland: Add fixup patch to add missing include * fixup: Fix for storage quota test case
OS-14345: Add a webpreference to disable pinch to zoom In chromium pinch to zoom can be disabled globally using the command line switch disable-pinch. BrightSign has a requirement to beable to disable pinch to zoom at a browser window level. This patch adds enable_pinch_zoom as a webpreference and sets its value in RenderWidgetHostViewEventHandler. The webpreference will present on all platforms, but the change to set it is only present in aura (linux). The webpreference will only be used if disable-pinch has not been set on the command line. Cherry picked from: c3ca6fb: feat: Add a webpreference to disable pinch to zoom (#24) Signed-off-by: Tariq Bashir <120014322+t-bashir-bs@users.noreply.github.com>
Weston backend refuses to send deletion requests outside selection area. Newly written text is in selection area, but old text is not. This casues old text to be not deletable. Deleting outside the selection area doesn't seem to be a problem as in EXO window manager mentioned in the code comment. Cherry picked from: f768e1f: fix: Fix weston-keyboard backspace problem with existing text
wayland: Retry display server connection before giving up Brightsign weston server instance might not be up when Electron tries to connect to it. Added a patch to force 5 retries one second apart before giving up on it. Co-authored-by: Caner Altinbasak <cal@brightsign.biz> Cherry picked from: 7678214: fix: Retry wayland display server connection before giving up (#29)
Added the Chromium patch for integrating Brightsign video player with Chromium. fix: Fix assertion with multiple video player instances. OS-15582 (#25) Renderer diffrentiates between video player instances using the DelegateId. Derive WebMediaPlayerBrightsign from WebMediaPlayerDelegate::Observer and initialise WebMediaPlayerDelegate instance. Provide DelegateId when Observer requests for it to avoid assertion. video: Compositor integration for Brightsign Video Player Brightsign video player uses a customised version of VideoHoleFrames, which sends video player factory and z-index of the video frames. These are handled as Overlay planes. Our custom BrightsignUnderlay strategy sends the geometry, opacity and visibility information via libvid. feat: WebMediaPlayerBrightsign: Set new is_video_tag param in vid_player_load (#32) WebMediaPlayerBrightsign: Set new is_video_tag param in vid_player_load feat: Add latest fixes to compositor integration for Brightsign VideoPlayer (#33) feat: Add latest fixes to compositor integration for Brightsign Video Player Update the existing BrightSign custom BrightsignUnderlay strategy code with the latest fixes that were made in the QtWebEngine version. fix: Pass attributes to video_player and correct conversion OS-16220 (#34) The html5 element attributes were not been set when passed to video_player_load. Also, some time parameters were being converted from std::chrono to int64 when passed to the c wrapper. However, they weren't being converted back correctly. Specifically the duration parameter when set to std::chrono::milliseconds::zero() was being treated as an int64 and therefore ending up with an incorrect negative value. fix: Add fix for single video with hwz cannot be hidden OS-16518 (#35) webmediaplayer_brightsign: Apply the fix for OnceCallback crash OS-16749 Applied the webmediaplayer_brightsign for the OnceCallback crash found in OS-16749. Cherry picked from: dc2f2de: feat: Add support for brightsign video player f4078f1: fix: Fix assertion with multiple video player instances. OS-15582 (#25) 8609bc5: video: Compositor integration for Brightsign Video Player 6e1d724: feat: WebMediaPlayerBrightsign: Set new is_video_tag param in vid_player_load (#32) 51d48c1: feat: Add latest fixes to compositor integration for Brightsign VideoPlayer (#33) 0febd19: fix: Pass attributes to video_player and correct conversion OS-16220 (#34) 55e3edd: fix: Add fix for single video with hwz cannot be hidden OS-16518 (#35) 7017af4: webmediaplayer_brightsign: Apply the fix for OnceCallback crash OS-16749
caneraltinbasak
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Branch 23-x-y-bs has 33 commits containing custom BrightSign changes. These have been cherry picked and tidied up and and this PR contains those changes. Of the 33 commits, 31 have been cherry picked, with one ignored as the changes have been upstreamed and one (feat: Add SetOpacity functionality to linux ozone wayland: OS-16623 (#41)) will be done later as the changes will be repartitioned so that the wayland protocol updates will be made in BS Weston repo instead. The 31 commits have been cherry picked and squashed into 16 commits. It has been verified the both "Test" and "Release" CI steps are passing.
The csv file below contains details of what was done for each commit.
commit-info-23-x-y-bs.csv
Checklist
npm test
passesRelease Notes
Notes: