fix #57 test requirements and CI tests pull brightway2 #59
Conversation
|
this is in reference to issue #57 |
|
If this pipeline definition with azure succeeds, it could also be tested in relation to bw2calc issue 55 |
|
This is amazing! I have been unable to understand why the pip tests weren't working, and of course it is a dumb, simple error. However, I removed |
Did you mean I'll work this out. |
tngTUDOR
changed the title
|
removing ...
install_requires=[
"bw_processing",
"matrix_utils",
"numpy",
"pandas",
"scipy",
"stats_arrays",
],
...>>> import bw2calc as bc
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/code/bw2calc/__init__.py", line 55, in <module>
from .multi_lca import MultiLCA
File "/code/bw2calc/multi_lca.py", line 2, in <module>
from bw2data import calculation_setups
ModuleNotFoundError: No module named 'bw2data'I'll revert the changes to setup.py and requirements and create a separate issue for this. -> issue #60 |
|
The solution for the pipelines to pass was to use a virtualenv for the ubuntu-20.04-pip based testing env. |
bw2data and matrix_utils are necessary, not the whole brightway2[5] package. Previous pipeline setup was installing brightway2, hence bringing all the deps of the brightway2 metapackage, but the master branch of the bw2cal repo is now for brightway25, so we shouldn't bring old deps, and we should only bring the necessary ones (not bw2io for example) This commit also adds a pip virtual environment for the failning ubuntu-pip setup of the testing 👷 test code being checked-out by installing first By installing the code from source, we test the current master branch, or the code offered in a PR. ⬇️ package has dependency on bw2data not brightway2 Using bw2data as dependency keeps a coherent set of deps. Testing dependencies are only about third party libraries required for testing, and are different to *install_requires*.
|
@cmutel , I did not add a version bmp to the PR, and I decided to keep the bw2data dependency because otherwise, the package would be broken (see comment above). #60 has the issue explaining why we cannot remove bw2data from deps (MultiLCA needs it) I think we can merge this, without releasing, then update MultiLCA to not depend on bw2data [if at all possible] and then do the bump. |
merging this might need a version bump (not included in the commit).