New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[_ColorPalette] Restructure Class and remove hardcoded shades of colors #381
Comments
BiancaMorandi
added
function improvement
Add improvements to an existing function or feature
and removed
bug
Something isn't working
labels
Feb 15, 2023
BiancaMorandi
added a commit
that referenced
this issue
Feb 16, 2023
BiancaMorandi
added a commit
that referenced
this issue
May 8, 2023
BiancaMorandi
added a commit
that referenced
this issue
May 8, 2023
BiancaMorandi
added a commit
that referenced
this issue
May 11, 2023
BiancaMorandi
added a commit
that referenced
this issue
May 12, 2023
BiancaMorandi
added a commit
that referenced
this issue
May 12, 2023
BiancaMorandi
added a commit
that referenced
this issue
May 12, 2023
BiancaMorandi
added a commit
that referenced
this issue
May 12, 2023
BiancaMorandi
added a commit
that referenced
this issue
May 12, 2023
BiancaMorandi
added a commit
that referenced
this issue
May 16, 2023
BiancaMorandi
added
bug
Something isn't working
and removed
function improvement
Add improvements to an existing function or feature
labels
May 16, 2023
BiancaMorandi
added a commit
that referenced
this issue
May 16, 2023
BiancaMorandi
added a commit
that referenced
this issue
May 16, 2023
stephenholleran
added a commit
that referenced
this issue
May 17, 2023
stephenholleran
added a commit
that referenced
this issue
May 17, 2023
stephenholleran
added a commit
that referenced
this issue
May 17, 2023
stephenholleran
added a commit
that referenced
this issue
May 17, 2023
stephenholleran
added a commit
that referenced
this issue
May 17, 2023
BiancaMorandi
added a commit
that referenced
this issue
May 17, 2023
BiancaMorandi
added a commit
that referenced
this issue
May 17, 2023
stephenholleran
added a commit
that referenced
this issue
May 17, 2023
BiancaMorandi
added a commit
that referenced
this issue
May 17, 2023
Thanks @BiancaMorandi ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ISSUE
_ColorPalette
Class lists many colors without having any link between each others:self.primary_10
is a hardcoded color that is 10% of the primary color -> it would be better for this color to be defined in function ofself.primary
and not to be hardcodedself.color_list
doesn't have any impact on the inputs colors used for this list e.gself.primary
,self.secondary
etc... and viceversa,
self.secondaryetc. doesn't have any impact on
self._color_map` and viceversaUPDATES TO MAKE
This Class should be improved to have dependencies between
self.color_list
,self._color_map
and each single color and between primary colors and derived shades of the same color.The text was updated successfully, but these errors were encountered: