Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[_ColorPalette] Restructure Class and remove hardcoded shades of colors #381

Closed
BiancaMorandi opened this issue Feb 14, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@BiancaMorandi
Copy link
Contributor

BiancaMorandi commented Feb 14, 2023

ISSUE
_ColorPalette Class lists many colors without having any link between each others:

  • e.g. self.primary_10 is a hardcoded color that is 10% of the primary color -> it would be better for this color to be defined in function of self.primary and not to be hardcoded
  • a change of colors listed by self.color_list doesn't have any impact on the inputs colors used for this list e.g self.primary , self.secondary etc... and viceversa
  • a change of self.primary , self.secondaryetc. doesn't have any impact onself._color_map` and viceversa

UPDATES TO MAKE
This Class should be improved to have dependencies between self.color_list, self._color_map and each single color and between primary colors and derived shades of the same color.

@BiancaMorandi BiancaMorandi added the bug Something isn't working label Feb 14, 2023
@BiancaMorandi BiancaMorandi self-assigned this Feb 14, 2023
@BiancaMorandi BiancaMorandi moved this from To do to In progress in brightwind kanban Feb 15, 2023
@BiancaMorandi BiancaMorandi added function improvement Add improvements to an existing function or feature and removed bug Something isn't working labels Feb 15, 2023
BiancaMorandi added a commit that referenced this issue Mar 23, 2023
BiancaMorandi added a commit that referenced this issue May 9, 2023
BiancaMorandi added a commit that referenced this issue May 12, 2023
@BiancaMorandi BiancaMorandi moved this from In progress to Awaiting Approval in brightwind kanban May 12, 2023
@BiancaMorandi BiancaMorandi added bug Something isn't working and removed function improvement Add improvements to an existing function or feature labels May 16, 2023
BiancaMorandi added a commit that referenced this issue May 16, 2023
BiancaMorandi added a commit that referenced this issue May 16, 2023
stephenholleran added a commit that referenced this issue May 17, 2023
@stephenholleran
Copy link
Collaborator

Thanks @BiancaMorandi !

@stephenholleran stephenholleran moved this from Awaiting Approval to Done in brightwind kanban May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

2 participants