[Iss310] different colours plot scatter

[BiancaMorandi]

1. updated the plot_scatter , plot_scatter_by_sector to give as input to _scatter_subplot the scatter and trendline colors
2. updated plot_timeseries default line_colors input option

[stephenholleran]

Hi @BiancaMorandi ,

The below code should set the trendline to yellow. But it doesn't?

bw.analyse.plot.COLOR_PALETTE.primary = '#FF0000' # Red
bw.analyse.plot.COLOR_PALETTE.secondary = '#FFFF00' # Yellow
data = bw.load_csv(bw.demo_datasets.demo_data)
WSPD_COLS = ['Spd80mN', 'Spd80mS', 'Spd60mN', 'Spd60mS', 'Spd40mN', 'Spd40mS']
display(bw.plot_scatter_wspd(data[WSPD_COLS[0]],data[WSPD_COLS[1]]))

[BiancaMorandi]

bw.analyse.plot.COLOR_PALETTE.primary = '#FF0000' # Red
bw.analyse.plot.COLOR_PALETTE.secondary = '#FFFF00' # Yellow
data = bw.load_csv(bw.demo_datasets.demo_data)
WSPD_COLS = ['Spd80mN', 'Spd80mS', 'Spd60mN', 'Spd60mS', 'Spd40mN', 'Spd40mS']
display(bw.plot_scatter_wspd(data[WSPD_COLS[0]],data[WSPD_COLS[1]]))

@stephenholleran color you have changed is for the trendline and what you are looking at is the 1:1 line for which color is defined at the moment as bw.analyse.plot.COLOR_PALETTE.secondary_70. if you run code below you will get what you expect. I think that we should replace any variable defining the shade of a color with a function calculating this based on the update of the main color.

bw.analyse.plot.COLOR_PALETTE.primary = '#FF0000' # Red
bw.analyse.plot.COLOR_PALETTE.secondary_70 = '#FFFF00' # Yellow
data = bw.load_csv(bw.demo_datasets.demo_data)
WSPD_COLS = ['Spd80mN', 'Spd80mS', 'Spd60mN', 'Spd60mS', 'Spd40mN', 'Spd40mS']
display(bw.plot_scatter_wspd(data[WSPD_COLS[0]],data[WSPD_COLS[1]]))```

[stephenholleran]

Ah, I should be running this:

---

I think that we should replace any variable defining the shade of a color with a function calculating this based on the update of the main color.

Good idea. Could you create a card to capture this. We probably need to restructure the whole _ColorPalette class so this can be part of it.

[BiancaMorandi]

Good idea. Could you create a card to capture this. We probably need to restructure the whole _ColorPalette class so this can be part of it.

Opened issue #381